Bug 146960

Summary: [EFL] Implements the button of the scrollbar.
Product: WebKit Reporter: Hunseop Jeong <hs85.jeong>
Component: WebKit EFLAssignee: Hunseop Jeong <hs85.jeong>
Status: RESOLVED WONTFIX    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, mcatanzaro, ryuan.choi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch achristensen: review-

Description Hunseop Jeong 2015-07-14 23:23:53 PDT 
Added the button of the scrollbar and remove the unnecessary color property in edc.
Comment 1 Hunseop Jeong 2015-07-15 00:16:45 PDT 
Created attachment 256826 [details]
Patch
Comment 2 Ryuan Choi 2015-07-15 00:34:34 PDT 
Comment on attachment 256826 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256826&action=review

> Source/WebCore/platform/efl/ScrollbarThemeEfl.cpp:46
> +static const int buttonLength = 10;

Can we have different value of buttonLength from thickness?
Comment 3 Gyuyoung Kim 2015-07-15 00:47:01 PDT 
Comment on attachment 256826 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256826&action=review

> Source/WebCore/ChangeLog:21
> +          calculate the size of button and paint the button.`

Remove ` at the end of line.

> Source/WebCore/platform/efl/DefaultTheme/widget/scrollbar/scrollbar.edc:115
> +                   * If wants to draw on top, just overflow using edje's rel1/rel2

Wrong indentation.

> Source/WebCore/platform/efl/DefaultTheme/widget/scrollbar/scrollbar.edc:165
> +                    * If wants to draw on top, just overflow using edje's rel1/rel2

ditto.

> Source/WebCore/platform/efl/ScrollbarThemeEfl.cpp:128
> +    if (part == BackButtonStartPart)

In this case, switch ~ case looks better.
Comment 4 Hunseop Jeong 2015-07-17 02:41:39 PDT 
Created attachment 256964 [details]
Patch
Comment 5 Hunseop Jeong 2015-07-17 03:09:37 PDT 
(In reply to comment #2)
> Comment on attachment 256826 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256826&action=review
> 
> > Source/WebCore/platform/efl/ScrollbarThemeEfl.cpp:46
> > +static const int buttonLength = 10;
> 
> Can we have different value of buttonLength from thickness?

Should we have the same value?
Comment 6 Hunseop Jeong 2015-07-17 03:20:01 PDT 
Created attachment 256965 [details]
Patch
Comment 7 Hunseop Jeong 2015-07-17 03:23:00 PDT 
Created attachment 256966 [details]
Patch
Comment 8 Hunseop Jeong 2015-07-17 03:26:27 PDT 
(In reply to comment #3)
> Comment on attachment 256826 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256826&action=review
> 
> > Source/WebCore/ChangeLog:21
> > +          calculate the size of button and paint the button.`
> 
> Remove ` at the end of line.
> 
> > Source/WebCore/platform/efl/DefaultTheme/widget/scrollbar/scrollbar.edc:115
> > +                   * If wants to draw on top, just overflow using edje's rel1/rel2
> 
> Wrong indentation.
> 
> > Source/WebCore/platform/efl/DefaultTheme/widget/scrollbar/scrollbar.edc:165
> > +                    * If wants to draw on top, just overflow using edje's rel1/rel2
> 
> ditto.
> 
> > Source/WebCore/platform/efl/ScrollbarThemeEfl.cpp:128
> > +    if (part == BackButtonStartPart)
> 
> In this case, switch ~ case looks better.

Done. I will be more careful about the small mistakes :(
Comment 9 Alex Christensen 2017-03-03 08:32:28 PST 
Comment on attachment 256966 [details]
Patch

EFL port was removed.  This patch is no longer needed in trunk.
Comment 10 Michael Catanzaro 2017-03-11 10:44:49 PST 
Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.