| Summary: | Analysis tasks that start at the very first data point doesn't load | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
| Component: | WebKit Website | Assignee: | Ryosuke Niwa <rniwa> | ||||
| Status: | RESOLVED WONTFIX | ||||||
| Severity: | Normal | CC: | cdumez, dbates, dewei_zhu, kling | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Ryosuke Niwa
2015-07-14 17:12:57 PDT
Created attachment 256812 [details]
Fixes the bug
Comment on attachment 256812 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=256812&action=review > Websites/perf.webkit.org/public/v2/data.js:534 > + if (!('seriesIndex' in endPoint)) This is not correct. Notice that the existing logic prevented indexing into this._series with a negative index. > Websites/perf.webkit.org/public/v2/data.js:541 > + if (!('seriesIndex' in endPoint)) I take it you meant to write "point" instead of "endPoint" in the expression for this if-statement. (In reply to comment #2) > Comment on attachment 256812 [details] > Fixes the bug > > View in context: > https://bugs.webkit.org/attachment.cgi?id=256812&action=review > > > Websites/perf.webkit.org/public/v2/data.js:534 > > + if (!('seriesIndex' in endPoint)) > > [...] Notice that the existing logic prevented indexing into > this._series with a negative index. I meant to write: Notice that the existing logic prevented indexing into this._series with a negative index when point.seriesIndex == 0. This patch is obsolete now. |