Bug 146952

Summary: Analysis tasks that start at the very first data point doesn't load
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: WebKit WebsiteAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED WONTFIX    
Severity: Normal CC: cdumez, dbates, dewei_zhu, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the bug dbates: review-

Ryosuke Niwa
Reported 2015-07-14 17:12:57 PDT
JavaScript blows up :(
Attachments
Fixes the bug (1.90 KB, patch)
2015-07-14 17:18 PDT, Ryosuke Niwa 		dbates: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2015-07-14 17:18:36 PDT
Created attachment 256812 [details] Fixes the bug
Daniel Bates
Comment 2 2015-07-15 22:30:32 PDT
Comment on attachment 256812 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=256812&action=review > Websites/perf.webkit.org/public/v2/data.js:534 > + if (!('seriesIndex' in endPoint)) This is not correct. Notice that the existing logic prevented indexing into this._series with a negative index. > Websites/perf.webkit.org/public/v2/data.js:541 > + if (!('seriesIndex' in endPoint)) I take it you meant to write "point" instead of "endPoint" in the expression for this if-statement.
Daniel Bates
Comment 3 2015-07-15 22:32:39 PDT
(In reply to comment #2) > Comment on attachment 256812 [details] > Fixes the bug > > View in context: > https://bugs.webkit.org/attachment.cgi?id=256812&action=review > > > Websites/perf.webkit.org/public/v2/data.js:534 > > + if (!('seriesIndex' in endPoint)) > > [...] Notice that the existing logic prevented indexing into > this._series with a negative index. I meant to write: Notice that the existing logic prevented indexing into this._series with a negative index when point.seriesIndex == 0.
Ryosuke Niwa
Comment 4 2015-10-09 03:29:34 PDT
This patch is obsolete now.
Note You need to log in before you can comment on or make changes to this bug.