Bug 146944

Summary:

Web Inspector: TimelineRuler minimum selection time range should be configurable

Product:

WebKit

Reporter:

Matt Baker <mattbaker>

Component:

Web Inspector

Assignee:

Matt Baker <mattbaker>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Patch] Proposed Fix	none

Description Matt Baker 2015-07-14 15:02:47 PDT

* SUMMARY
TimelineRuler minimum selection time range should be configurable. The rendering frames overview uses a non-time horizontal axis, and should specify a minimum selection of one frame.

Comment 1 Radar WebKit Bug Importer 2015-07-14 15:03:06 PDT

<rdar://problem/21822720>

Comment 2 Matt Baker 2015-07-14 15:13:18 PDT

Created attachment 256799 [details]
[Patch] Proposed Fix

Comment 3 Joseph Pecoraro 2015-07-14 15:26:42 PDT

Comment on attachment 256799 [details]
[Patch] Proposed Fix

r=me!

Perhaps we should also make it that clicking without any drag selects the frame where you clicked. Right now you have to drag at least a tiny bit for the selection to trigger. But this does feel much better.

Comment 4 Matt Baker 2015-07-14 15:47:00 PDT

(In reply to comment #3)
> Comment on attachment 256799 [details]
> [Patch] Proposed Fix
> 
> r=me!
> 
> Perhaps we should also make it that clicking without any drag selects the
> frame where you clicked. Right now you have to drag at least a tiny bit for
> the selection to trigger. But this does feel much better.

This is already being done as part of rdar://problem/2122352, when the user clicks a single frame outside the current selection. :)

Comment 5 Matt Baker 2015-07-14 15:47:54 PDT

(In reply to comment #4)
> (In reply to comment #3)
> > Comment on attachment 256799 [details]
> > [Patch] Proposed Fix
> > 
> > r=me!
> > 
> > Perhaps we should also make it that clicking without any drag selects the
> > frame where you clicked. Right now you have to drag at least a tiny bit for
> > the selection to trigger. But this does feel much better.
> 
> This is already being done as part of rdar://problem/2122352, when the user
> clicks a single frame outside the current selection. :)

But we could always break it out as a stand-alone patch.

Comment 6 WebKit Commit Bot 2015-07-14 16:39:15 PDT

Comment on attachment 256799 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 256799

Committed r186824: <http://trac.webkit.org/changeset/186824>

Comment 7 WebKit Commit Bot 2015-07-14 16:39:18 PDT

All reviewed patches have been landed.  Closing bug.