Bug 146937

Summary: Don't persist history item tree for subframes across reloads.
Product: WebKit Reporter: Andreas Kling <kling>
Component: HistoryAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, buildbot, commit-queue, japhet, kling, rniwa
Priority: P2 Keywords: InRadar, Performance
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
buildbot: commit-queue-
Archive of layout-test-results from ews104 for mac-mavericks-wk2
none
Patch beidson: review+

Andreas Kling
Reported 2015-07-14 13:36:55 PDT
<rdar://problem/19925709>
Attachments
Patch (1.71 KB, patch)
2015-07-14 13:40 PDT, Andreas Kling 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (603.19 KB, application/zip)
2015-07-14 14:51 PDT, Build Bot 		no flags
Details
Patch (1.71 KB, patch)
2015-07-14 15:23 PDT, Andreas Kling 		beidson: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2015-07-14 13:40:34 PDT
Created attachment 256791 [details] Patch
Build Bot
Comment 2 2015-07-14 14:51:09 PDT
Comment on attachment 256791 [details] Patch Attachment 256791 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5734265333481472 New failing tests: svg/W3C-SVG-1.1/animate-elem-02-t.svg
Build Bot
Comment 3 2015-07-14 14:51:11 PDT
Created attachment 256797 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Andreas Kling
Comment 4 2015-07-14 15:23:29 PDT
Created attachment 256801 [details] Patch
Brady Eidson
Comment 5 2015-07-14 16:51:58 PDT
Comment on attachment 256801 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256801&action=review > Source/WebCore/loader/HistoryController.cpp:346 > + // Just rebuild the history item tree when reloading, since trying to re-associate everything would be too error-prone. Since a comment is pretty much half the patch, I have to nitpick. // Rebuild the history item tree when reloading as trying to re-associate everything is too error-prone.
Andreas Kling
Comment 6 2015-07-14 19:13:30 PDT
Committed r186828: <http://trac.webkit.org/changeset/186828>
Andreas Kling
Comment 7 2015-07-14 19:14:32 PDT
Comment on attachment 256801 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256801&action=review >> Source/WebCore/loader/HistoryController.cpp:346 >> + // Just rebuild the history item tree when reloading, since trying to re-associate everything would be too error-prone. > > Since a comment is pretty much half the patch, I have to nitpick. > > // Rebuild the history item tree when reloading as trying to re-associate everything is too error-prone. You got it :)
Andreas Kling
Comment 8 2015-07-14 19:14:33 PDT
Comment on attachment 256801 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256801&action=review >> Source/WebCore/loader/HistoryController.cpp:346 >> + // Just rebuild the history item tree when reloading, since trying to re-associate everything would be too error-prone. > > Since a comment is pretty much half the patch, I have to nitpick. > > // Rebuild the history item tree when reloading as trying to re-associate everything is too error-prone. You got it :)
Note You need to log in before you can comment on or make changes to this bug.