| Summary: | iOS WebKit doesn't build. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yongjun Zhang <yongjun_zhang> | ||||||
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | andersca, commit-queue, mitz, sam, thorton | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Yongjun Zhang
2015-07-13 14:46:23 PDT
Created attachment 256730 [details]
Patch.
Comment on attachment 256730 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=256730&action=review > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3185 > + _previewing = [window.rootViewController registerForPreviewingWithSourceView:self]; Do we need to retain this? I’ve already fixed the build in r186779 but moving off the deprecated API is better. (In reply to comment #3) > Comment on attachment 256730 [details] > Patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=256730&action=review > > > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3185 > > + _previewing = [window.rootViewController registerForPreviewingWithSourceView:self]; > > Do we need to retain this? yeah, I think we need to. Will Change. Created attachment 256734 [details]
Fix the conflict.
Comment on attachment 256734 [details] Fix the conflict. View in context: https://bugs.webkit.org/attachment.cgi?id=256734&action=review > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3197 > + _previewing.delegate = nil; > [_previewGestureRecognizer setDelegate:nil]; > _previewGestureRecognizer = nil; > + [_previewing release]; Should we do these two new things (clearing the delegate and releasing) in our -dealloc too, just in case? (In reply to comment #7) > Comment on attachment 256734 [details] > Fix the conflict. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=256734&action=review > > > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3197 > > + _previewing.delegate = nil; > > [_previewGestureRecognizer setDelegate:nil]; > > _previewGestureRecognizer = nil; > > + [_previewing release]; > > Should we do these two new things (clearing the delegate and releasing) in > our -dealloc too, just in case? I don't think it's needed. We will do the cleanup when the view is removed from window, which should be done before dealloc. Comment on attachment 256734 [details] Fix the conflict. Clearing flags on attachment: 256734 Committed r186808: <http://trac.webkit.org/changeset/186808> All reviewed patches have been landed. Closing bug. |