Bug 146917 – iOS WebKit doesn't build.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Yongjun Zhang]

We shouldn't use deprecated UIVC API for preview.

[Yongjun Zhang]

Created attachment 256730 [details]
Patch.

[Yongjun Zhang]

rdar://problem/21801544

Comment on attachment 256730 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=256730&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3185
> +    _previewing = [window.rootViewController registerForPreviewingWithSourceView:self];

Do we need to retain this?

I’ve already fixed the build in r186779 but moving off the deprecated API is better.

[Yongjun Zhang]

(In reply to comment #3)
> Comment on attachment 256730 [details]
> Patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256730&action=review
> 
> > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3185
> > +    _previewing = [window.rootViewController registerForPreviewingWithSourceView:self];
> 
> Do we need to retain this?

yeah, I think we need to. Will Change.

[Yongjun Zhang]

Created attachment 256734 [details]
Fix the conflict.

Comment on attachment 256734 [details]
Fix the conflict.

View in context: https://bugs.webkit.org/attachment.cgi?id=256734&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3197
> +    _previewing.delegate = nil;
>      [_previewGestureRecognizer setDelegate:nil];
>      _previewGestureRecognizer = nil;
> +    [_previewing release];

Should we do these two new things (clearing the delegate and releasing) in our -dealloc too, just in case?

[Yongjun Zhang]

(In reply to comment #7)
> Comment on attachment 256734 [details]
> Fix the conflict.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256734&action=review
> 
> > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3197
> > +    _previewing.delegate = nil;
> >      [_previewGestureRecognizer setDelegate:nil];
> >      _previewGestureRecognizer = nil;
> > +    [_previewing release];
> 
> Should we do these two new things (clearing the delegate and releasing) in
> our -dealloc too, just in case?

I don't think it's needed. We will do the cleanup when the view is removed from window, which should be done before dealloc.

[WebKit Commit Bot]

Comment on attachment 256734 [details]
Fix the conflict.

Clearing flags on attachment: 256734

Committed r186808: <http://trac.webkit.org/changeset/186808>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.