Bug 146897

Summary:

If Watchpoint::fire() looks at the state of the world, it should definitely see its set invalidated, and maybe it should see the object of interest in the transitioned-to state

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, basile_clement, benjamin, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, saam, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	none
the patch	mark.lam: review+

Description Filip Pizlo 2015-07-12 21:43:19 PDT

Patch forthcoming.

Comment 1 Filip Pizlo 2015-07-12 21:51:21 PDT

Created attachment 256685 [details]
the patch

Comment 2 Filip Pizlo 2015-07-12 21:54:44 PDT

Created attachment 256686 [details]
the patch

moar changelog.

Comment 3 Mark Lam 2015-07-13 08:41:56 PDT

Comment on attachment 256686 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256686&action=review

r=me

> Source/JavaScriptCore/ChangeLog:34
> +        it would fine that the singleton object's structure is no longer watchable. This is

typo: fine => find.

Comment 4 Filip Pizlo 2015-07-13 13:11:25 PDT

Landed in http://trac.webkit.org/changeset/186776