Bug 146894

Summary: REGRESSION (r177876): store.apple.com profile and cart icons are missing
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mark.lam, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 146943    
Bug Blocks:    
Attachments:
Description Flags
patch mmaxfield: review+

Antti Koivisto
Reported 2015-07-12 13:49:56 PDT
Two competing @font-face rules with only one having the correct glyphs.
Attachments
patch (36.04 KB, patch)
2015-07-12 15:02 PDT, Antti Koivisto 		mmaxfield: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2015-07-12 13:50:17 PDT
rdar://problem/21736723
Antti Koivisto
Comment 2 2015-07-12 15:02:26 PDT
Created attachment 256683 [details] patch
Alexey Proskuryakov
Comment 3 2015-07-12 15:34:11 PDT
Comment on attachment 256683 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=256683&action=review > LayoutTests/fast/css/font-face-multiple-missing-glyphs-expected.html:7 > + font-family:AppleIcons; Is this available under an appropriate license?
Antti Koivisto
Comment 4 2015-07-12 15:41:16 PDT
> Is this available under an appropriate license? No idea.
Myles C. Maxfield
Comment 5 2015-07-13 13:48:15 PDT
Comment on attachment 256683 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=256683&action=review r=me > Source/WebCore/platform/graphics/FontCascadeFonts.cpp:339 > + ++fallbackIndex; I don't understand. It doesn't look like there is a "continue" anywhere in the loop which will cause this to be skipped. Why did you move this to the bottom of the loop? >> LayoutTests/fast/css/font-face-multiple-missing-glyphs-expected.html:7 >> + font-family:AppleIcons; > > Is this available under an appropriate license? You can author your own font in SVG for this test. Should be straightforward.
Myles C. Maxfield
Comment 6 2015-07-14 12:52:00 PDT
Committed r186809: <http://trac.webkit.org/changeset/186809>
WebKit Commit Bot
Comment 7 2015-07-14 14:16:04 PDT
Re-opened since this is blocked by bug 146943
Mark Lam
Comment 8 2015-07-14 14:23:35 PDT
Rolled out in http://trac.webkit.org/changeset/186816.
Antti Koivisto
Comment 9 2015-07-14 16:18:58 PDT
Thanks for updating the test case but you probably didn't want to include the SimpleLineLayout.cpp change.
Myles C. Maxfield
Comment 10 2015-07-14 16:32:08 PDT
(In reply to comment #9) > Thanks for updating the test case but you probably didn't want to include > the SimpleLineLayout.cpp change. hahah .... whoops. :(
Myles C. Maxfield
Comment 11 2015-07-14 17:24:53 PDT
Committed r186827: <http://trac.webkit.org/changeset/186827>
Note You need to log in before you can comment on or make changes to this bug.