Bug 146888

Summary:

[EFL] Editing tests have been broken since r186694

Product:

WebKit

Reporter:

Gyuyoung Kim <gyuyoung.kim>

Component:

WebKit EFL

Assignee:

Hunseop Jeong <hs85.jeong>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, hs85.jeong, lucas.de.marchi, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

146836

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Gyuyoung Kim

Reported 2015-07-11 23:40:05 PDT

SSIA. editing/selection/5354455-1.html [ Failure ] editing/selection/5354455-2.html [ Failure ] editing/spelling/context-menu-suggestions-multiword-selection.html [ Failure ] editing/spelling/context-menu-suggestions-subword-selection.html [ Failure ] editing/spelling/context-menu-suggestions.html [ Failure ]

Attachments
Patch (3.61 KB, patch) 2015-08-04 06:01 PDT, Hunseop Jeong	no flags	Details Formatted Diff Diff
Patch (3.62 KB, patch) 2015-08-04 06:30 PDT, Hunseop Jeong	no flags	Details Formatted Diff Diff
Patch (3.57 KB, patch) 2015-08-04 06:33 PDT, Hunseop Jeong	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Brent Fulgham

Comment 1 2015-07-24 09:16:24 PDT

This was probably due to my change here: @@ -474,9 +476,5 @@ JSContextRef context = WKBundleFrameGetJavaScriptContext(mainFrame); #if ENABLE(CONTEXT_MENUS) - // Do mouse context click. - mouseDown(2, 0); - mouseUp(2, 0); - - WKRetainPtr<WKArrayRef> menuEntries = adoptWK(WKBundlePageCopyContextMenuItems(page)); + WKRetainPtr<WKArrayRef> menuEntries = adoptWK(WKBundlePageCopyContextMenuAtPointInWindow(page, m_position)); JSValueRef arrayResult = JSObjectMakeArray(context, 0, 0, 0); JSObjectRef arrayObj = JSValueToObject(context, arrayResult, 0); On Mac, the context menu is modal, so no further WebKit activity happens until the dialog is dismissed. So we can't use the mouseDown/mouseUp combination here -- it just blocks the test from running. Maybe you could just #if/def my change so thet it works like it used to on EFL and uses my revised code for Mac/Windows, and perhaps Gtk.

Hunseop Jeong

Comment 2 2015-08-04 06:01:51 PDT

Created attachment 258173 [details] Patch

Hunseop Jeong

Comment 3 2015-08-04 06:05:51 PDT

Could I restore the codes?

Hunseop Jeong

Comment 4 2015-08-04 06:30:48 PDT

Created attachment 258174 [details] Patch

Hunseop Jeong

Comment 5 2015-08-04 06:33:33 PDT

Created attachment 258175 [details] Patch