Bug 146881

Summary:

Get rid of the implicit NSGeometry type conversions

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

NEW

Severity:

Normal

CC:

beidson, buildbot, commit-queue, dbates, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	beidson: review-, buildbot: commit-queue-
Archive of layout-test-results from ews106 for mac-mavericks-wk2	none

Anders Carlsson

Reported 2015-07-11 14:20:18 PDT

Get rid of the implicit NSGeometry type conversions

Attachments
Patch (170.47 KB, patch) 2015-07-11 14:22 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (170.64 KB, patch) 2015-07-11 14:42 PDT, Anders Carlsson	beidson: review- buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (566.44 KB, application/zip) 2015-07-11 15:33 PDT, Build Bot	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Anders Carlsson

Comment 1 2015-07-11 14:22:50 PDT

Created attachment 256665 [details] Patch

WebKit Commit Bot

Comment 2 2015-07-11 14:25:55 PDT

Attachment 256665 [details] did not pass style-queue: ERROR: Source/WebCore/editing/mac/AlternativeTextUIController.mm:96: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/mac/CorrectionPanel.mm:88: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit/mac/WebView/WebFrame.mm:713: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/Misc/WebIconDatabase.mm:141: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/mac/Misc/WebIconDatabase.mm:141: The parameter name "image" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/mac/WebCoreSupport/CorrectionPanel.mm:80: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 6 in 60 files If any of these errors are false positives, please file a bug against check-webkit-style.

Anders Carlsson

Comment 3 2015-07-11 14:42:15 PDT

Created attachment 256668 [details] Patch

WebKit Commit Bot

Comment 4 2015-07-11 14:43:51 PDT

Attachment 256668 [details] did not pass style-queue: ERROR: Source/WebCore/editing/mac/AlternativeTextUIController.mm:96: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/mac/CorrectionPanel.mm:88: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit/mac/WebView/WebFrame.mm:713: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/Misc/WebIconDatabase.mm:141: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/mac/Misc/WebIconDatabase.mm:141: The parameter name "image" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit/mac/WebCoreSupport/CorrectionPanel.mm:80: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 6 in 60 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 5 2015-07-11 15:33:29 PDT

Comment on attachment 256668 [details] Patch Attachment 256668 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5098151149043712 New failing tests: fast/replaced/object-with-embed-url-param.html

Build Bot

Comment 6 2015-07-11 15:33:32 PDT

Created attachment 256670 [details] Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Brent Fulgham

Comment 7 2016-01-13 14:03:00 PST

Comment on attachment 256668 [details] Patch Do we still want this patch? It seems like it may have bit rotten in the last six months. :-\

Brady Eidson

Comment 8 2017-04-24 19:11:20 PDT

Comment on attachment 256668 [details] Patch This patch has been pending review since 2015 with no recent activity. It seems unlikely that it would even still apply to trunk in its current form. Clearing from the review queue. Feel free to update and resubmit if the patch is still relevant.

Note You need to log in before you can comment on or make changes to this bug.