Bug 146875

Summary:

DFG::DesiredWatchpoints should accept WatchpointSetType's that aren't necessarily pointers

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, basile_clement, benjamin, ggaren, mark.lam, mhahnenb, mitz, mmirman, msaboff, nrotem, oliver, saam, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	mitz: review+

Filip Pizlo

Reported 2015-07-10 23:05:54 PDT

In the future we'll want to add a desired watchpoint set that's something like "please watch property 'Foo' for 'deletion' on structure 'S1'", so that the "set type" is struct like "struct MySet { StringImpl* property; Mode mode; Structure* structure };".

Attachments
the patch (4.96 KB, patch) 2015-07-10 23:08 PDT, Filip Pizlo	mitz: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2015-07-10 23:08:22 PDT

Created attachment 256646 [details] the patch

Filip Pizlo

Comment 2 2015-07-10 23:42:54 PDT

Landed in http://trac.webkit.org/changeset/186706

Note You need to log in before you can comment on or make changes to this bug.