| Summary: | DFG::DesiredWatchpoints should accept WatchpointSetType's that aren't necessarily pointers | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||
| Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | barraclough, basile_clement, benjamin, ggaren, mark.lam, mhahnenb, mitz, mmirman, msaboff, nrotem, oliver, saam, sam | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
Created attachment 256646 [details]
the patch
Landed in http://trac.webkit.org/changeset/186706 |
In the future we'll want to add a desired watchpoint set that's something like "please watch property 'Foo' for 'deletion' on structure 'S1'", so that the "set type" is struct like "struct MySet { StringImpl* property; Mode mode; Structure* structure };".