Bug 146873

Summary: [WK2] Diagnostic logging messages are causing too much IPC
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, kling, koivisto, rniwa
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2015-07-10 22:37:16 PDT 
Diagnostic logging messages are causing too much IPC.
Comment 1 Chris Dumez 2015-07-10 22:37:44 PDT 
rdar://problem/21779205
Comment 2 Chris Dumez 2015-07-10 22:48:41 PDT 
Created attachment 256644 [details]
Patch
Comment 3 Ryosuke Niwa 2015-07-10 23:46:02 PDT 
Comment on attachment 256644 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256644&action=review

> Source/WebCore/page/DiagnosticLoggingClient.h:45
> +    static bool shouldLogGivenSampling(ShouldSample);

I'm not certain if this is the most descriptive name.  How about isLogSelectedInSample or shouldLogAfterSampling?

> Source/WebCore/page/DiagnosticLoggingClient.h:56
> +    // Log 5% of messages when sampling.

I don't think we need this comment.  The code speaks for itself.

> Source/WebKit2/NetworkProcess/NetworkProcess.cpp:485
> +    parentProcessConnection()->send(Messages::NetworkProcessProxy::LogPreSampledDiagnosticMessage(webPageID, message, description), 0);

I don't think it makes sense to call these PreSampled.  If anything, these are post sampling.
Why don't we simply call it LogSampledDiagnosticMessage?
Comment 4 Chris Dumez 2015-07-10 23:54:23 PDT 
Created attachment 256649 [details]
Patch
Comment 5 Chris Dumez 2015-07-10 23:56:54 PDT 
Comment on attachment 256649 [details]
Patch

Clearing flags on attachment: 256649

Committed r186707: <http://trac.webkit.org/changeset/186707>
Comment 6 Chris Dumez 2015-07-10 23:56:58 PDT 
All reviewed patches have been landed.  Closing bug.