Bug 146863

Summary: Remove incorrect overriding of inputAssistantItem in WKContentView
Product: WebKit Reporter: Enrica Casucci <enrica>
Component: WebKit2Assignee: Enrica Casucci <enrica>
Status: RESOLVED FIXED    
Severity: Normal CC: mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
mitz: review+
Patch2
sam: review+
Patch3 sam: review+

Description Enrica Casucci 2015-07-10 18:01:40 PDT 
The keyboard is entirely responsible for this and WebKit should not override it.

rdar://problem/21507154
Comment 1 Enrica Casucci 2015-07-10 18:05:52 PDT 
Created attachment 256631 [details]
Patch
Comment 2 mitz 2015-07-10 18:13:04 PDT 
Comment on attachment 256631 [details]
Patch

r=me assuming you tested this change in isolation (without related UIKit changes).
Comment 3 Enrica Casucci 2015-07-11 11:59:35 PDT 
(In reply to comment #2)
> Comment on attachment 256631 [details]
> Patch
> 
> r=me assuming you tested this change in isolation (without related UIKit
> changes).

I did. In fact the WebKit changes but itself is enough to fixe the bug. The UIKit changes are for cleanup and to fix WK1.
Thank you!
Comment 4 Enrica Casucci 2015-07-11 12:03:44 PDT 
Committed revision 186713.
Comment 5 Enrica Casucci 2015-07-11 13:41:59 PDT 
Found a bug in the previous patch. Reopening.
Comment 6 Enrica Casucci 2015-07-11 13:56:06 PDT 
Created attachment 256664 [details]
Patch2
Comment 7 Enrica Casucci 2015-07-11 14:28:50 PDT 
Created attachment 256666 [details]
Patch3

Fix the iOS EWS.
Comment 8 Enrica Casucci 2015-07-11 14:32:10 PDT 
Committed revision 186716.