Bug 146863

Summary: Remove incorrect overriding of inputAssistantItem in WKContentView
Product: WebKit Reporter: Enrica Casucci <enrica>
Component: WebKit2Assignee: Enrica Casucci <enrica>
Status: RESOLVED FIXED    
Severity: Normal CC: mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
mitz: review+
Patch2
sam: review+
Patch3 sam: review+

Enrica Casucci
Reported 2015-07-10 18:01:40 PDT
The keyboard is entirely responsible for this and WebKit should not override it. rdar://problem/21507154
Attachments
Patch (2.75 KB, patch)
2015-07-10 18:05 PDT, Enrica Casucci 		mitz: review+
DetailsFormatted DiffDiff
Patch2 (2.09 KB, patch)
2015-07-11 13:56 PDT, Enrica Casucci 		sam: review+
DetailsFormatted DiffDiff
Patch3 (2.15 KB, patch)
2015-07-11 14:28 PDT, Enrica Casucci 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Enrica Casucci
Comment 1 2015-07-10 18:05:52 PDT
Created attachment 256631 [details] Patch
mitz
Comment 2 2015-07-10 18:13:04 PDT
Comment on attachment 256631 [details] Patch r=me assuming you tested this change in isolation (without related UIKit changes).
Enrica Casucci
Comment 3 2015-07-11 11:59:35 PDT
(In reply to comment #2) > Comment on attachment 256631 [details] > Patch > > r=me assuming you tested this change in isolation (without related UIKit > changes). I did. In fact the WebKit changes but itself is enough to fixe the bug. The UIKit changes are for cleanup and to fix WK1. Thank you!
Enrica Casucci
Comment 4 2015-07-11 12:03:44 PDT
Committed revision 186713.
Enrica Casucci
Comment 5 2015-07-11 13:41:59 PDT
Found a bug in the previous patch. Reopening.
Enrica Casucci
Comment 6 2015-07-11 13:56:06 PDT
Created attachment 256664 [details] Patch2
Enrica Casucci
Comment 7 2015-07-11 14:28:50 PDT
Created attachment 256666 [details] Patch3 Fix the iOS EWS.
Enrica Casucci
Comment 8 2015-07-11 14:32:10 PDT
Committed revision 186716.
Note You need to log in before you can comment on or make changes to this bug.