Bug 146843

Summary:

Crash at WebCore::WebPage::innerFrameQuad.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ddkilzer, enrica, kling

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description zalan 2015-07-10 11:18:11 PDT

Crash at WebCore::WebPage::innerFrameQuad

Comment 1 zalan 2015-07-10 11:18:45 PDT

rdar://problem/21501819

Comment 2 zalan 2015-07-10 11:28:56 PDT

Created attachment 256595 [details]
Patch

Comment 3 Andreas Kling 2015-07-10 11:36:36 PDT

Comment on attachment 256595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256595&action=review

r=me

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:782
> +    RenderObject* renderer = nullptr;

This should be a RenderElement*.

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:786
> +    else if (assistedNode.rootEditableElement())
> +        renderer = assistedNode.rootEditableElement()->renderer();

Can we avoid computing rootEditableElement() twice here?

Comment 4 zalan 2015-07-10 12:24:31 PDT

Created attachment 256601 [details]
Patch

Comment 5 WebKit Commit Bot 2015-07-10 13:20:59 PDT

Comment on attachment 256601 [details]
Patch

Clearing flags on attachment: 256601

Committed r186684: <http://trac.webkit.org/changeset/186684>

Comment 6 WebKit Commit Bot 2015-07-10 13:21:03 PDT

All reviewed patches have been landed.  Closing bug.