Bug 146841

Summary: [WK2][iOS] Fix build with !ENABLE(NETWORK_PROCESS)
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED WONTFIX    
Severity: Normal CC: andersca, ap, barraclough, cgarcia, commit-queue, koivisto, rniwa, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Chris Dumez 2015-07-10 10:53:44 PDT
Fix build with !ENABLE(NETWORK_PROCESS).
Comment 1 Anders Carlsson 2015-07-10 11:01:46 PDT
Why do we need this working at all?
Comment 2 Chris Dumez 2015-07-10 11:04:43 PDT
(In reply to comment #1)
> Why do we need this working at all?

Maintaining this configuration is useful for testing purposes. For e.g., we are currently investigating a possible IPC perf regression.
Comment 3 Chris Dumez 2015-07-10 11:19:24 PDT
Created attachment 256594 [details]
Patch
Comment 4 Anders Carlsson 2015-07-10 11:34:19 PDT
(In reply to comment #2)
> (In reply to comment #1)
> > Why do we need this working at all?
> 
> Maintaining this configuration is useful for testing purposes. For e.g., we
> are currently investigating a possible IPC perf regression.

From what? From enabling the Network Process? The non-network process configuration has never shipped on iOS.
Comment 5 Chris Dumez 2015-07-10 12:14:12 PDT
Hmm, there is a WebProcessPool::setUsesNetworkProcess() to do this at run time. At the moment, this is only exposed via a private C API but I guess this is enough for testing.
Comment 6 Alexey Proskuryakov 2015-07-10 23:14:25 PDT
It is likely that disabling NetworkProcess at runtime will change too much for being a useful testing tool. We won't use WebKit persistent cache, and I believe that CFNetwork cache is already broken on iOS due to some path/sandboxing confusion.