Bug 146840

Summary: Media Session: handle 'Transient' and 'Transient Solo' interruption events
Product: WebKit Reporter: Matt Rajca <mrajca>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: conrad_shultz, eric.carlson, jer.noble, mrajca, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 145411    
Attachments:
Description Flags
Patch
none
Patch
none
Patch eric.carlson: review+

Description Matt Rajca 2015-07-10 10:45:42 PDT 
Implement the media session interruption algorithm for 'Transient' start-of-interruption events (4.5.2).
Comment 1 Radar WebKit Bug Importer 2015-07-10 10:46:29 PDT 
<rdar://problem/21768970>
Comment 2 Matt Rajca 2015-07-10 10:52:02 PDT 
Created attachment 256591 [details]
Patch
Comment 3 Matt Rajca 2015-07-10 13:48:35 PDT 
Created attachment 256609 [details]
Patch
Comment 4 Matt Rajca 2015-07-16 14:02:42 PDT 
Created attachment 256922 [details]
Patch
Comment 5 Eric Carlson 2015-07-16 14:15:30 PDT 
Comment on attachment 256922 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256922&action=review

> Source/WebCore/Modules/mediasession/MediaSession.cpp:252
> +    m_currentState = State::Interrupted;

Shouldn't this be "Active"?

> Source/WebCore/Modules/mediasession/MediaSession.cpp:257
> +    m_currentState = State::Active;

Shouldn't this be "Interrupted"?
Comment 6 Matt Rajca 2015-07-16 16:33:46 PDT 
(In reply to comment #5)
> Comment on attachment 256922 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256922&action=review
> 
> > Source/WebCore/Modules/mediasession/MediaSession.cpp:252
> > +    m_currentState = State::Interrupted;
> 
> Shouldn't this be "Active"?
> 
> > Source/WebCore/Modules/mediasession/MediaSession.cpp:257
> > +    m_currentState = State::Active;
> 
> Shouldn't this be "Interrupted"?

Yes, for both. These got mixed up when I was moving things around.
Comment 7 Matt Rajca 2015-07-16 16:37:46 PDT 
Committed r186918: <http://trac.webkit.org/changeset/186918>