Bug 146840

Summary: Media Session: handle 'Transient' and 'Transient Solo' interruption events
Product: WebKit Reporter: Matt Rajca <mrajca>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: conrad_shultz, eric.carlson, jer.noble, mrajca, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 145411    
Attachments:
Description Flags
Patch
none
Patch
none
Patch eric.carlson: review+

Matt Rajca
Reported 2015-07-10 10:45:42 PDT
Implement the media session interruption algorithm for 'Transient' start-of-interruption events (4.5.2).
Attachments
Patch (6.57 KB, patch)
2015-07-10 10:52 PDT, Matt Rajca 		no flags
DetailsFormatted DiffDiff
Patch (18.06 KB, patch)
2015-07-10 13:48 PDT, Matt Rajca 		no flags
DetailsFormatted DiffDiff
Patch (12.56 KB, patch)
2015-07-16 14:02 PDT, Matt Rajca 		eric.carlson: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-07-10 10:46:29 PDT
<rdar://problem/21768970>
Matt Rajca
Comment 2 2015-07-10 10:52:02 PDT
Created attachment 256591 [details] Patch
Matt Rajca
Comment 3 2015-07-10 13:48:35 PDT
Created attachment 256609 [details] Patch
Matt Rajca
Comment 4 2015-07-16 14:02:42 PDT
Created attachment 256922 [details] Patch
Eric Carlson
Comment 5 2015-07-16 14:15:30 PDT
Comment on attachment 256922 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256922&action=review > Source/WebCore/Modules/mediasession/MediaSession.cpp:252 > + m_currentState = State::Interrupted; Shouldn't this be "Active"? > Source/WebCore/Modules/mediasession/MediaSession.cpp:257 > + m_currentState = State::Active; Shouldn't this be "Interrupted"?
Matt Rajca
Comment 6 2015-07-16 16:33:46 PDT
(In reply to comment #5) > Comment on attachment 256922 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=256922&action=review > > > Source/WebCore/Modules/mediasession/MediaSession.cpp:252 > > + m_currentState = State::Interrupted; > > Shouldn't this be "Active"? > > > Source/WebCore/Modules/mediasession/MediaSession.cpp:257 > > + m_currentState = State::Active; > > Shouldn't this be "Interrupted"? Yes, for both. These got mixed up when I was moving things around.
Matt Rajca
Comment 7 2015-07-16 16:37:46 PDT
Committed r186918: <http://trac.webkit.org/changeset/186918>
Note You need to log in before you can comment on or make changes to this bug.