Bug 146840 - Media Session: handle 'Transient' and 'Transient Solo' interruption events
Summary: Media Session: handle 'Transient' and 'Transient Solo' interruption events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 145411
  Show dependency tree / graph
 
Reported: 2015-07-10 10:45 PDT by Matt Rajca
Modified: 2015-07-16 16:37 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.57 KB, patch)
2015-07-10 10:52 PDT, Matt Rajca 		no flags Details | Formatted Diff | Diff
Patch (18.06 KB, patch)
2015-07-10 13:48 PDT, Matt Rajca 		no flags Details | Formatted Diff | Diff
Patch (12.56 KB, patch)
2015-07-16 14:02 PDT, Matt Rajca 		eric.carlson: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Rajca 2015-07-10 10:45:42 PDT 
Implement the media session interruption algorithm for 'Transient' start-of-interruption events (4.5.2).
Comment 1 Radar WebKit Bug Importer 2015-07-10 10:46:29 PDT 
<rdar://problem/21768970>
Comment 2 Matt Rajca 2015-07-10 10:52:02 PDT 
Created attachment 256591 [details]
Patch
Comment 3 Matt Rajca 2015-07-10 13:48:35 PDT 
Created attachment 256609 [details]
Patch
Comment 4 Matt Rajca 2015-07-16 14:02:42 PDT 
Created attachment 256922 [details]
Patch
Comment 5 Eric Carlson 2015-07-16 14:15:30 PDT 
Comment on attachment 256922 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256922&action=review

> Source/WebCore/Modules/mediasession/MediaSession.cpp:252
> +    m_currentState = State::Interrupted;

Shouldn't this be "Active"?

> Source/WebCore/Modules/mediasession/MediaSession.cpp:257
> +    m_currentState = State::Active;

Shouldn't this be "Interrupted"?
Comment 6 Matt Rajca 2015-07-16 16:33:46 PDT 
(In reply to comment #5)
> Comment on attachment 256922 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256922&action=review
> 
> > Source/WebCore/Modules/mediasession/MediaSession.cpp:252
> > +    m_currentState = State::Interrupted;
> 
> Shouldn't this be "Active"?
> 
> > Source/WebCore/Modules/mediasession/MediaSession.cpp:257
> > +    m_currentState = State::Active;
> 
> Shouldn't this be "Interrupted"?

Yes, for both. These got mixed up when I was moving things around.
Comment 7 Matt Rajca 2015-07-16 16:37:46 PDT 
Committed r186918: <http://trac.webkit.org/changeset/186918>