Bug 146839

Summary: Change load(MediaStreamPrivate*) method to use references
Product: WebKit Reporter: Matthew Daiter <mdaiter>
Component: WebCore Misc.Assignee: Matthew Daiter <mdaiter>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, eric.carlson, jonlee, mdaiter, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar, PlatformOnly
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 146788    
Attachments:
Description Flags
Patch
none
Patch
none
Patch darin: review+

Matthew Daiter
Reported 2015-07-10 10:45:26 PDT
MediaPlayerPrivateInterface derivatives should be able to load MediaStreamPrivate methods without worrying about whether the MediaStreamPrivate is null or not.
Attachments
Patch (6.58 KB, patch)
2015-07-10 10:55 PDT, Matthew Daiter 		no flags
DetailsFormatted DiffDiff
Patch (8.13 KB, patch)
2015-07-10 13:33 PDT, Matthew Daiter 		no flags
DetailsFormatted DiffDiff
Patch (8.12 KB, patch)
2015-07-10 16:45 PDT, Matthew Daiter 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-07-10 10:48:04 PDT
<rdar://problem/21769035>
Matthew Daiter
Comment 2 2015-07-10 10:55:21 PDT
Created attachment 256592 [details] Patch
Matthew Daiter
Comment 3 2015-07-10 13:33:56 PDT
Created attachment 256607 [details] Patch
Darin Adler
Comment 4 2015-07-10 13:46:24 PDT
Comment on attachment 256607 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256607&action=review So no one uses this argument yet? > Source/WebCore/platform/graphics/MediaPlayer.cpp:427 > + m_private->load(*m_mediaStream.get()); Should not need .get() here. > Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.h:64 > + virtual void load(MediaStreamPrivate&) override { }; Should remove the stray semicolon here.
Matthew Daiter
Comment 5 2015-07-10 16:45:03 PDT
Created attachment 256626 [details] Patch
Brent Fulgham
Comment 6 2015-07-13 10:06:49 PDT
*** Bug 146811 has been marked as a duplicate of this bug. ***
Brent Fulgham
Comment 7 2015-07-13 11:38:19 PDT
Turning off cq+, because Matthew hasn't addressed Darin's comments.
Brent Fulgham
Comment 8 2015-07-13 12:46:37 PDT
(In reply to comment #4) > Comment on attachment 256607 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=256607&action=review > > So no one uses this argument yet? > > > Source/WebCore/platform/graphics/MediaPlayer.cpp:427 > > + m_private->load(*m_mediaStream.get()); > > Should not need .get() here. I'll fix while landing. > > Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.h:64 > > + virtual void load(MediaStreamPrivate&) override { }; > > Should remove the stray semicolon here. Ditto.
Brent Fulgham
Comment 9 2015-07-13 12:51:51 PDT
Committed r186769: <http://trac.webkit.org/changeset/186769>
Note You need to log in before you can comment on or make changes to this bug.