Bug 146836

Summary:

[Mac] Unable to dismiss context menu during test runs

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

Tools / Tests

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, bfulgham, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

146888

Bug Blocks:

146695

Attachments:

Description	Flags
Patch	thorton: review+

Brent Fulgham

Reported 2015-07-10 10:05:43 PDT

The Mac port has a number of layout tests that are skipped because they timeout. The timeout is caused by the context menu not being dismissed during the test. Some tests attempt to dismiss the context menu by trying to process an escape character, but this doesn't seem to reliably trigger the menu to be dismissed. A quick review of mac-wk2 TestExpectations shows several tests suffering from this problem: editing/selection/5354455-1.html editing/selection/5354455-2.html editing/selection/button-right-click.html editing/selection/context-menu-on-text.html editing/selection/context-menu-text-selection-lookup.html editing/selection/context-menu-text-selection.html editing/selection/empty-cell-right-click.html editing/spelling/context-menu-suggestions-multiword-selection.html editing/spelling/context-menu-suggestions-subword-selection.html editing/spelling/context-menu-suggestions.html editing/spelling/spellcheck-input-search-crash.html fast/events/context-no-deselect.html fast/events/context-nodrag.html fast/events/context-onmousedown-event.html fast/events/contextmenu-scrolled-page-with-frame.html fast/events/right-click-focus.html fast/events/selectstart-prevent-selection-on-right-click.html media/controls-right-click-on-timebar.html

Attachments
Patch (4.90 KB, patch) 2015-07-10 15:41 PDT, Brent Fulgham	thorton: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Brent Fulgham

Comment 1 2015-07-10 15:41:28 PDT

Created attachment 256620 [details] Patch

Brent Fulgham

Comment 2 2015-07-10 15:41:56 PDT

Once this patch is landed I will reactivate the failing tests.

Brent Fulgham

Comment 3 2015-07-10 16:11:03 PDT

Committed r186694: <http://trac.webkit.org/changeset/186694>

Brent Fulgham

Comment 4 2015-07-10 17:15:52 PDT

It looks like editing/selection/5354455-{1,2}.html still fail due to poor Win/Unix emulation on Mac. I'll leave these skipped.

Brent Fulgham

Comment 5 2015-07-10 17:20:46 PDT

Two more failures: editing/spelling/context-menu-suggestions-multiword-selection.html editing/spelling/context-menu-suggestions-subword-selection.html These seem to time out due to spelling support problems.

Brent Fulgham

Comment 6 2015-07-10 17:36:41 PDT

Two last failures: fast/events/right-click-focus.html: This fails because Mac doesn't seem to shift focus when context menu is being driven in DRT/WKTR. fast/events/context-onmousedown-event.html: An actual mouse-down event isn't being emitted by DRT/WKTR.

Brent Fulgham

Comment 7 2015-07-10 17:41:19 PDT

Unskipped tests in r186699.

Note You need to log in before you can comment on or make changes to this bug.