Bug 146829

Summary: Enable STATIC_ASSERT_IS_TRIVIALLY_DESTRUCTIBLE for GCC
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, andersca, bfulgham, commit-queue, kling, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 120785    
Attachments:
Description Flags
Patch
none
Patch none

Csaba Osztrogonác
Reported 2015-07-10 02:57:29 PDT
http://trac.webkit.org/changeset/155143 disabled STATIC_ASSERT_IS_TRIVIALLY_DESTRUCTIBLE on GCC builds due to http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52702 . But this bug is already solved long time ago, we already relies on newer GCC.
Attachments
Patch (1.76 KB, patch)
2015-07-10 02:58 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (1.71 KB, patch)
2015-07-22 08:37 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2015-07-10 02:58:21 PDT
Created attachment 256572 [details] Patch
Darin Adler
Comment 2 2015-07-10 09:52:56 PDT
Comment on attachment 256572 [details] Patch What port is building with non-clang gcc? I’m not sure we should do the work to support that any more unless there is real benefit.
Csaba Osztrogonác
Comment 3 2015-07-10 09:54:35 PDT
(In reply to comment #2) > Comment on attachment 256572 [details] > Patch > > What port is building with non-clang gcc? I’m not sure we should do the work > to support that any more unless there is real benefit. EFL and GTK.
Anders Carlsson
Comment 4 2015-07-10 10:38:07 PDT
Comment on attachment 256572 [details] Patch I think a better solution would be to just reimplement std::is_trivially_destructible in terms of std::has_trivial_destructor for MSVC and get rid of the compiler checks altogether.
Csaba Osztrogonác
Comment 5 2015-07-22 08:37:06 PDT
Created attachment 257273 [details] Patch Additionally removed the MSVC workaround since MSVC 2012 already supports std::is_trivially_destructible.
Csaba Osztrogonác
Comment 6 2015-07-22 08:41:57 PDT
(In reply to comment #5) > Created attachment 257273 [details] > Patch > > Additionally removed the MSVC workaround since MSVC 2012 already supports > std::is_trivially_destructible. And now MSVC 2013 is mandatory - https://lists.webkit.org/pipermail/webkit-dev/2013-December/025941.html
Brent Fulgham
Comment 7 2015-07-22 09:50:51 PDT
Comment on attachment 257273 [details] Patch This looks good! Thanks.
WebKit Commit Bot
Comment 8 2015-07-22 11:05:32 PDT
Comment on attachment 257273 [details] Patch Clearing flags on attachment: 257273 Committed r187167: <http://trac.webkit.org/changeset/187167>
WebKit Commit Bot
Comment 9 2015-07-22 11:05:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.