| Summary: | [CoordinatedGraphics] Override primaryLayerID in CoordinatedGraphicsLayer | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryuan Choi <ryuan.choi> | ||||
| Component: | WebKit EFL | Assignee: | Ryuan Choi <ryuan.choi> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cmarcelo, commit-queue, kondapallykalyan, lucas.de.marchi, luiz, noam | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Ryuan Choi
2015-07-10 00:27:09 PDT
Created attachment 256570 [details]
Patch
Comment on attachment 256570 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256570&action=review > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:124 > + CoordinatedLayerID id() const { return m_id; } primaryLayerID() just returns id(). So I'm not 100% sure if we should continue to keep id(). r+ed for now. (In reply to comment #2) > Comment on attachment 256570 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=256570&action=review > > > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:124 > > + CoordinatedLayerID id() const { return m_id; } > > primaryLayerID() just returns id(). So I'm not 100% sure if we should > continue to keep id(). r+ed for now. While PlatformLayerID is uint64_t, CoordinatedGraphicsLayer uses uint32_t as id and id is widely used including IPC message. If refactoring does not have critical performance regression, we can remove id. I will check it. Comment on attachment 256570 [details] Patch Clearing flags on attachment: 256570 Committed r186700: <http://trac.webkit.org/changeset/186700> All reviewed patches have been landed. Closing bug. |