Bug 146817

Summary:

[Content Extensions] Cache domain actions

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

WebCore Misc.

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	benjamin: review+

Description Alex Christensen 2015-07-09 15:50:07 PDT

Right now we run regular expressions on the domain every time we have any rules that match with if-domain or unless-domain.  This caches the results of running regular expressions on the domain of the main document's url so we only need to run those regular expressions when the main document changes domain.

Comment 1 Alex Christensen 2015-07-09 15:54:28 PDT

Created attachment 256536 [details]
Patch

Comment 2 Alex Christensen 2015-07-10 18:21:27 PDT

Created attachment 256635 [details]
Patch

Comment 3 Alex Christensen 2015-07-14 15:24:32 PDT

Created attachment 256802 [details]
Patch

Comment 4 Alex Christensen 2015-07-14 16:45:39 PDT

Created attachment 256809 [details]
Patch

Comment 5 Alex Christensen 2015-07-15 08:52:13 PDT

I measured this to be about a 25% improvement in interpreting time in one case.

Comment 6 Benjamin Poulain 2015-07-16 14:41:59 PDT

Comment on attachment 256809 [details]
Patch

lgtm

Comment 7 Alex Christensen 2015-07-16 15:09:52 PDT

http://trac.webkit.org/changeset/186912