RESOLVED FIXED146817
[Content Extensions] Cache domain actions 
https://bugs.webkit.org/show_bug.cgi?id=146817
Summary [Content Extensions] Cache domain actions
Alex Christensen
Reported 2015-07-09 15:50:07 PDT
Right now we run regular expressions on the domain every time we have any rules that match with if-domain or unless-domain. This caches the results of running regular expressions on the domain of the main document's url so we only need to run those regular expressions when the main document changes domain.
Attachments
Patch (14.90 KB, patch)
2015-07-09 15:54 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (18.86 KB, patch)
2015-07-10 18:21 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (23.25 KB, patch)
2015-07-14 15:24 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (19.04 KB, patch)
2015-07-14 16:45 PDT, Alex Christensen 		benjamin: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2015-07-09 15:54:28 PDT
Created attachment 256536 [details] Patch
Alex Christensen
Comment 2 2015-07-10 18:21:27 PDT
Created attachment 256635 [details] Patch
Alex Christensen
Comment 3 2015-07-14 15:24:32 PDT
Created attachment 256802 [details] Patch
Alex Christensen
Comment 4 2015-07-14 16:45:39 PDT
Created attachment 256809 [details] Patch
Alex Christensen
Comment 5 2015-07-15 08:52:13 PDT
I measured this to be about a 25% improvement in interpreting time in one case.
Benjamin Poulain
Comment 6 2015-07-16 14:41:59 PDT
Comment on attachment 256809 [details] Patch lgtm
Alex Christensen
Comment 7 2015-07-16 15:09:52 PDT
http://trac.webkit.org/changeset/186912
Note You need to log in before you can comment on or make changes to this bug.