Bug 146817 - [Content Extensions] Cache domain actions
Summary: [Content Extensions] Cache domain actions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-09 15:50 PDT by Alex Christensen
Modified: 2015-07-16 15:09 PDT (History)
0 users

See Also:

Attachments
Patch (14.90 KB, patch)
2015-07-09 15:54 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (18.86 KB, patch)
2015-07-10 18:21 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (23.25 KB, patch)
2015-07-14 15:24 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (19.04 KB, patch)
2015-07-14 16:45 PDT, Alex Christensen 		benjamin: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2015-07-09 15:50:07 PDT 
Right now we run regular expressions on the domain every time we have any rules that match with if-domain or unless-domain.  This caches the results of running regular expressions on the domain of the main document's url so we only need to run those regular expressions when the main document changes domain.
Comment 1 Alex Christensen 2015-07-09 15:54:28 PDT 
Created attachment 256536 [details]
Patch
Comment 2 Alex Christensen 2015-07-10 18:21:27 PDT 
Created attachment 256635 [details]
Patch
Comment 3 Alex Christensen 2015-07-14 15:24:32 PDT 
Created attachment 256802 [details]
Patch
Comment 4 Alex Christensen 2015-07-14 16:45:39 PDT 
Created attachment 256809 [details]
Patch
Comment 5 Alex Christensen 2015-07-15 08:52:13 PDT 
I measured this to be about a 25% improvement in interpreting time in one case.
Comment 6 Benjamin Poulain 2015-07-16 14:41:59 PDT 
Comment on attachment 256809 [details]
Patch

lgtm
Comment 7 Alex Christensen 2015-07-16 15:09:52 PDT 
http://trac.webkit.org/changeset/186912