Bug 146814

Summary:

It should be possible to run the OSR exit fuzzer

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

Tools / Tests

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, basile_clement, benjamin, commit-queue, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, saam, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	mark.lam: review+

Description Filip Pizlo 2015-07-09 15:22:51 PDT

Currently the jsc binary supports it, but there is no harness to wrap it.

Comment 1 Filip Pizlo 2015-07-09 15:57:20 PDT

Created attachment 256537 [details]
the patch

Comment 2 WebKit Commit Bot 2015-07-09 15:58:36 PDT

Attachment 256537 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/Options.cpp:392:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/runtime/Options.cpp:397:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Saam Barati 2015-07-09 23:39:09 PDT

Comment on attachment 256537 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256537&action=review

Looks good to me.

> Tools/Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:126
> +            $optionToUse = "--fireOSRExitFuzzAtOrAfter=1";

I think there could be a better name for this option. Will this always fire at and after the index passed in?
If so, maybe: "fireOSRExitFuzzStartingAt"

Comment 4 Filip Pizlo 2015-07-10 13:55:34 PDT

(In reply to comment #3)
> Comment on attachment 256537 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256537&action=review
> 
> Looks good to me.
> 
> > Tools/Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:126
> > +            $optionToUse = "--fireOSRExitFuzzAtOrAfter=1";
> 
> I think there could be a better name for this option. Will this always fire
> at and after the index passed in?
> If so, maybe: "fireOSRExitFuzzStartingAt"

Fair point.  Maybe we can change that in another patch - I've already landed a lot of code that calls it fireOSRExitFuzzAtOrAfter.

Comment 5 Mark Lam 2015-07-10 14:10:06 PDT

Comment on attachment 256537 [details]
the patch

r=me

Comment 6 Filip Pizlo 2015-07-10 14:17:18 PDT

Landed in http://trac.webkit.org/changeset/186688