Bug 146813

Summary: Expose webkitMediaStream as MediaStream
Product: WebKit Reporter: Matthew Daiter <mdaiter>
Component: WebCore Misc.Assignee: Matthew Daiter <mdaiter>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, buildbot, cdumez, commit-queue, eric.carlson, jonlee, mdaiter, rniwa, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar, PlatformOnly
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 146746    
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews103 for mac-mavericks
none
Archive of layout-test-results from ews105 for mac-mavericks-wk2
none
Patch
none
Archive of layout-test-results from ews105 for mac-mavericks-wk2
none
Archive of layout-test-results from ews102 for mac-mavericks
none
Patch
none
Archive of layout-test-results from ews101 for mac-mavericks
none
Archive of layout-test-results from ews104 for mac-mavericks-wk2
none
Patch
none
Patch none

Description Matthew Daiter 2015-07-09 14:40:51 PDT
Need to fix this in order to conform to the format in which createObjectURL wants in DOMURLMediaStream
Comment 1 Radar WebKit Bug Importer 2015-07-09 14:41:53 PDT
<rdar://problem/21754383>
Comment 2 Matthew Daiter 2015-07-09 14:43:29 PDT
Created attachment 256523 [details]
Patch
Comment 3 Matthew Daiter 2015-07-09 15:02:33 PDT
Created attachment 256530 [details]
Patch
Comment 4 Matthew Daiter 2015-07-09 15:03:09 PDT
Needed to create certain patches for tests that weren't updated
Comment 5 Brent Fulgham 2015-07-09 15:10:40 PDT
This looks fine, but I think eric should review to make sure webkitMediaStream -> MediaStream doesn't break something or do something bad to Media clients.
Comment 6 Matthew Daiter 2015-07-09 15:11:55 PDT
Sounds good, although shouldn't our tests account for that?
Comment 7 Eric Carlson 2015-07-09 15:17:27 PDT
(In reply to comment #6)
> Sounds good, although shouldn't our tests account for that?

I assume the existing tests need to be updated for this change?
Comment 8 Build Bot 2015-07-09 15:46:27 PDT
Comment on attachment 256530 [details]
Patch

Attachment 256530 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5143959122739200

New failing tests:
js/dom/constructor-length.html
js/dom/global-constructors-attributes.html
Comment 9 Build Bot 2015-07-09 15:46:29 PDT
Created attachment 256534 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 10 Build Bot 2015-07-09 15:48:06 PDT
Comment on attachment 256530 [details]
Patch

Attachment 256530 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5366369709195264

New failing tests:
js/dom/constructor-length.html
js/dom/global-constructors-attributes.html
Comment 11 Build Bot 2015-07-09 15:48:08 PDT
Created attachment 256535 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 12 Matthew Daiter 2015-07-09 17:33:45 PDT
Created attachment 256545 [details]
Patch
Comment 13 Build Bot 2015-07-09 18:00:45 PDT
Comment on attachment 256545 [details]
Patch

Attachment 256545 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4589390797996032

New failing tests:
js/dom/constructor-length.html
Comment 14 Build Bot 2015-07-09 18:00:49 PDT
Created attachment 256548 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 15 Build Bot 2015-07-09 18:12:57 PDT
Comment on attachment 256545 [details]
Patch

Attachment 256545 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5658399568035840

New failing tests:
js/dom/constructor-length.html
Comment 16 Build Bot 2015-07-09 18:13:00 PDT
Created attachment 256549 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 17 Matthew Daiter 2015-07-09 18:41:00 PDT
Created attachment 256555 [details]
Patch
Comment 18 Build Bot 2015-07-09 19:14:55 PDT
Comment on attachment 256555 [details]
Patch

Attachment 256555 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5992178656477184

New failing tests:
js/dom/constructor-length.html
Comment 19 Build Bot 2015-07-09 19:14:59 PDT
Created attachment 256557 [details]
Archive of layout-test-results from ews101 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 20 Build Bot 2015-07-09 19:24:40 PDT
Comment on attachment 256555 [details]
Patch

Attachment 256555 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5733973812576256

New failing tests:
js/dom/constructor-length.html
Comment 21 Build Bot 2015-07-09 19:24:43 PDT
Created attachment 256558 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 22 Matthew Daiter 2015-07-10 10:11:48 PDT
Created attachment 256582 [details]
Patch
Comment 23 Chris Dumez 2015-07-10 10:21:12 PDT
Comment on attachment 256582 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256582&action=review

> Source/WebCore/Modules/mediastream/MediaStream.idl:32
> +    InterfaceName=MediaStream,

Just drop this line, this is already the interface name so it is now redundant.
Comment 24 Matthew Daiter 2015-07-10 10:26:53 PDT
Created attachment 256584 [details]
Patch
Comment 25 Matthew Daiter 2015-07-10 10:46:49 PDT
Comment on attachment 256582 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256582&action=review

>> Source/WebCore/Modules/mediastream/MediaStream.idl:32
>> +    InterfaceName=MediaStream,
> 
> Just drop this line, this is already the interface name so it is now redundant.

Done!
Comment 26 Chris Dumez 2015-07-10 10:50:38 PDT
(In reply to comment #25)
> Comment on attachment 256582 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256582&action=review
> 
> >> Source/WebCore/Modules/mediastream/MediaStream.idl:32
> >> +    InterfaceName=MediaStream,
> > 
> > Just drop this line, this is already the interface name so it is now redundant.
> 
> Done!

Thanks.
Comment 27 WebKit Commit Bot 2015-07-10 17:13:27 PDT
Comment on attachment 256584 [details]
Patch

Clearing flags on attachment: 256584

Committed r186697: <http://trac.webkit.org/changeset/186697>
Comment 28 WebKit Commit Bot 2015-07-10 17:13:35 PDT
All reviewed patches have been landed.  Closing bug.
Comment 29 Alex Christensen 2015-07-10 20:55:31 PDT
This made js/dom/global-constructors-attributes.html fail on yosemite.