Bug 146813

Summary:

Expose webkitMediaStream as MediaStream

Product:

WebKit

Reporter:

Matthew Daiter <mdaiter>

Component:

WebCore Misc.

Assignee:

Matthew Daiter <mdaiter>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bfulgham, buildbot, cdumez, commit-queue, eric.carlson, jonlee, mdaiter, rniwa, webkit-bug-importer, webkit.review.bot

Priority:

Keywords:

InRadar, PlatformOnly

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

146746

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews103 for mac-mavericks	none
Archive of layout-test-results from ews105 for mac-mavericks-wk2	none
Patch	none
Archive of layout-test-results from ews105 for mac-mavericks-wk2	none
Archive of layout-test-results from ews102 for mac-mavericks	none
Patch	none
Archive of layout-test-results from ews101 for mac-mavericks	none
Archive of layout-test-results from ews104 for mac-mavericks-wk2	none
Patch	none
Patch	none

Matthew Daiter

Reported 2015-07-09 14:40:51 PDT

Need to fix this in order to conform to the format in which createObjectURL wants in DOMURLMediaStream

Attachments
Patch (1.41 KB, patch) 2015-07-09 14:43 PDT, Matthew Daiter	no flags	Details Formatted Diff Diff
Patch (2.75 KB, patch) 2015-07-09 15:02 PDT, Matthew Daiter	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-mavericks (649.48 KB, application/zip) 2015-07-09 15:46 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (726.97 KB, application/zip) 2015-07-09 15:48 PDT, Build Bot	no flags	Details
Patch (11.08 KB, patch) 2015-07-09 17:33 PDT, Matthew Daiter	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (742.00 KB, application/zip) 2015-07-09 18:00 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews102 for mac-mavericks (532.13 KB, application/zip) 2015-07-09 18:13 PDT, Build Bot	no flags	Details
Patch (11.08 KB, patch) 2015-07-09 18:41 PDT, Matthew Daiter	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-mavericks (594.15 KB, application/zip) 2015-07-09 19:14 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (577.60 KB, application/zip) 2015-07-09 19:24 PDT, Build Bot	no flags	Details
Patch (11.08 KB, patch) 2015-07-10 10:11 PDT, Matthew Daiter	no flags	Details Formatted Diff Diff
Patch (11.04 KB, patch) 2015-07-10 10:26 PDT, Matthew Daiter	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-07-09 14:41:53 PDT

<rdar://problem/21754383>

Matthew Daiter

Comment 2 2015-07-09 14:43:29 PDT

Created attachment 256523 [details] Patch

Matthew Daiter

Comment 3 2015-07-09 15:02:33 PDT

Created attachment 256530 [details] Patch

Matthew Daiter

Comment 4 2015-07-09 15:03:09 PDT

Needed to create certain patches for tests that weren't updated

Brent Fulgham

Comment 5 2015-07-09 15:10:40 PDT

This looks fine, but I think eric should review to make sure webkitMediaStream -> MediaStream doesn't break something or do something bad to Media clients.

Matthew Daiter

Comment 6 2015-07-09 15:11:55 PDT

Sounds good, although shouldn't our tests account for that?

Eric Carlson

Comment 7 2015-07-09 15:17:27 PDT

(In reply to comment #6) > Sounds good, although shouldn't our tests account for that? I assume the existing tests need to be updated for this change?

Build Bot

Comment 8 2015-07-09 15:46:27 PDT

Comment on attachment 256530 [details] Patch Attachment 256530 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5143959122739200 New failing tests: js/dom/constructor-length.html js/dom/global-constructors-attributes.html

Build Bot

Comment 9 2015-07-09 15:46:29 PDT

Created attachment 256534 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 10 2015-07-09 15:48:06 PDT

Comment on attachment 256530 [details] Patch Attachment 256530 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5366369709195264 New failing tests: js/dom/constructor-length.html js/dom/global-constructors-attributes.html

Build Bot

Comment 11 2015-07-09 15:48:08 PDT

Created attachment 256535 [details] Archive of layout-test-results from ews105 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Matthew Daiter

Comment 12 2015-07-09 17:33:45 PDT

Created attachment 256545 [details] Patch

Build Bot

Comment 13 2015-07-09 18:00:45 PDT

Comment on attachment 256545 [details] Patch Attachment 256545 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4589390797996032 New failing tests: js/dom/constructor-length.html

Build Bot

Comment 14 2015-07-09 18:00:49 PDT

Created attachment 256548 [details] Archive of layout-test-results from ews105 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Build Bot

Comment 15 2015-07-09 18:12:57 PDT

Comment on attachment 256545 [details] Patch Attachment 256545 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5658399568035840 New failing tests: js/dom/constructor-length.html

Build Bot

Comment 16 2015-07-09 18:13:00 PDT

Created attachment 256549 [details] Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5

Matthew Daiter

Comment 17 2015-07-09 18:41:00 PDT

Created attachment 256555 [details] Patch

Build Bot

Comment 18 2015-07-09 19:14:55 PDT

Comment on attachment 256555 [details] Patch Attachment 256555 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5992178656477184 New failing tests: js/dom/constructor-length.html

Build Bot

Comment 19 2015-07-09 19:14:59 PDT

Created attachment 256557 [details] Archive of layout-test-results from ews101 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 20 2015-07-09 19:24:40 PDT

Comment on attachment 256555 [details] Patch Attachment 256555 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5733973812576256 New failing tests: js/dom/constructor-length.html

Build Bot

Comment 21 2015-07-09 19:24:43 PDT

Created attachment 256558 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Matthew Daiter

Comment 22 2015-07-10 10:11:48 PDT

Created attachment 256582 [details] Patch

Chris Dumez

Comment 23 2015-07-10 10:21:12 PDT

Comment on attachment 256582 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256582&action=review > Source/WebCore/Modules/mediastream/MediaStream.idl:32 > + InterfaceName=MediaStream, Just drop this line, this is already the interface name so it is now redundant.

Matthew Daiter

Comment 24 2015-07-10 10:26:53 PDT

Created attachment 256584 [details] Patch

Matthew Daiter

Comment 25 2015-07-10 10:46:49 PDT

Comment on attachment 256582 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256582&action=review >> Source/WebCore/Modules/mediastream/MediaStream.idl:32 >> + InterfaceName=MediaStream, > > Just drop this line, this is already the interface name so it is now redundant. Done!

Chris Dumez

Comment 26 2015-07-10 10:50:38 PDT

(In reply to comment #25) > Comment on attachment 256582 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=256582&action=review > > >> Source/WebCore/Modules/mediastream/MediaStream.idl:32 > >> + InterfaceName=MediaStream, > > > > Just drop this line, this is already the interface name so it is now redundant. > > Done! Thanks.

WebKit Commit Bot

Comment 27 2015-07-10 17:13:27 PDT

Comment on attachment 256584 [details] Patch Clearing flags on attachment: 256584 Committed r186697: <http://trac.webkit.org/changeset/186697>

WebKit Commit Bot

Comment 28 2015-07-10 17:13:35 PDT

All reviewed patches have been landed. Closing bug.

Alex Christensen

Comment 29 2015-07-10 20:55:31 PDT

This made js/dom/global-constructors-attributes.html fail on yosemite.

Note You need to log in before you can comment on or make changes to this bug.