Bug 146799

Summary: Web Inspector: Storage tab should have a scope bar in the sidebar
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Screenshot
none
Patch
none
Patch mark.lam: review+, timothy: commit-queue-

Timothy Hatcher
Reported 2015-07-09 12:52:02 PDT
Like the Resource tab, the Storage tab should have a scope bar at the top of the sidebar to make it fit in better.
Attachments
Patch (8.85 KB, patch)
2015-07-09 16:22 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Screenshot (181.89 KB, image/png)
2015-07-09 16:22 PDT, Timothy Hatcher 		no flags
Details
Patch (8.82 KB, patch)
2015-07-09 16:29 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Patch (9.17 KB, patch)
2015-07-09 16:59 PDT, Timothy Hatcher 		mark.lam: review+
timothy: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-07-09 12:52:15 PDT
<rdar://problem/21751880>
Timothy Hatcher
Comment 2 2015-07-09 16:22:08 PDT
Created attachment 256538 [details] Patch
Timothy Hatcher
Comment 3 2015-07-09 16:22:33 PDT
Created attachment 256539 [details] Screenshot
Timothy Hatcher
Comment 4 2015-07-09 16:29:41 PDT
Created attachment 256540 [details] Patch
Timothy Hatcher
Comment 5 2015-07-09 16:59:08 PDT
Created attachment 256542 [details] Patch
Mark Lam
Comment 6 2015-07-09 17:06:58 PDT
Comment on attachment 256542 [details] Patch r=me
Timothy Hatcher
Comment 7 2015-07-09 17:13:19 PDT
Comment on attachment 256542 [details] Patch r186654
Timothy Hatcher
Comment 8 2015-07-09 17:13:38 PDT
http://trac.webkit.org/changeset/186654
Mark Lam
Comment 9 2015-07-09 17:27:20 PDT
Comment on attachment 256542 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256542&action=review > Source/WebInspectorUI/UserInterface/Views/StorageSidebarPanel.js:49 > + {identifier: "local-sotrage", title: WebInspector.UIString("Local Storage"), classes: [WebInspector.DOMStorageTreeElement], localStorage: true}, > + {identifier: "session-sotrage", title: WebInspector.UIString("Session Storage"), classes: [WebInspector.DOMStorageTreeElement], localStorage: false}]; Oops. Just spotted these typos: "local-sotrage”, "session-sotrage"
Timothy Hatcher
Comment 10 2015-07-10 14:19:18 PDT
(In reply to comment #9) > Comment on attachment 256542 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=256542&action=review > > > Source/WebInspectorUI/UserInterface/Views/StorageSidebarPanel.js:49 > > + {identifier: "local-sotrage", title: WebInspector.UIString("Local Storage"), classes: [WebInspector.DOMStorageTreeElement], localStorage: true}, > > + {identifier: "session-sotrage", title: WebInspector.UIString("Session Storage"), classes: [WebInspector.DOMStorageTreeElement], localStorage: false}]; > > Oops. Just spotted these typos: "local-sotrage”, "session-sotrage" Fixed in a follow up. https://trac.webkit.org/r186690
Note You need to log in before you can comment on or make changes to this bug.