Bug 146799

Summary:

Web Inspector: Storage tab should have a scope bar in the sidebar

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Screenshot	none
Patch	none
Patch	mark.lam: review+, timothy: commit-queue-

Description Timothy Hatcher 2015-07-09 12:52:02 PDT

Like the Resource tab, the Storage tab should have a scope bar at the top of the sidebar to make it fit in better.

Comment 1 Radar WebKit Bug Importer 2015-07-09 12:52:15 PDT

<rdar://problem/21751880>

Comment 2 Timothy Hatcher 2015-07-09 16:22:08 PDT

Created attachment 256538 [details]
Patch

Comment 3 Timothy Hatcher 2015-07-09 16:22:33 PDT

Created attachment 256539 [details]
Screenshot

Comment 4 Timothy Hatcher 2015-07-09 16:29:41 PDT

Created attachment 256540 [details]
Patch

Comment 5 Timothy Hatcher 2015-07-09 16:59:08 PDT

Created attachment 256542 [details]
Patch

Comment 6 Mark Lam 2015-07-09 17:06:58 PDT

Comment on attachment 256542 [details]
Patch

r=me

Comment 7 Timothy Hatcher 2015-07-09 17:13:19 PDT

Comment on attachment 256542 [details]
Patch

r186654

Comment 8 Timothy Hatcher 2015-07-09 17:13:38 PDT

http://trac.webkit.org/changeset/186654

Comment 9 Mark Lam 2015-07-09 17:27:20 PDT

Comment on attachment 256542 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256542&action=review

> Source/WebInspectorUI/UserInterface/Views/StorageSidebarPanel.js:49
> +            {identifier: "local-sotrage", title: WebInspector.UIString("Local Storage"), classes: [WebInspector.DOMStorageTreeElement], localStorage: true},
> +            {identifier: "session-sotrage", title: WebInspector.UIString("Session Storage"), classes: [WebInspector.DOMStorageTreeElement], localStorage: false}];

Oops.  Just spotted these typos: "local-sotrage”, "session-sotrage"

Comment 10 Timothy Hatcher 2015-07-10 14:19:18 PDT

(In reply to comment #9)
> Comment on attachment 256542 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256542&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/StorageSidebarPanel.js:49
> > +            {identifier: "local-sotrage", title: WebInspector.UIString("Local Storage"), classes: [WebInspector.DOMStorageTreeElement], localStorage: true},
> > +            {identifier: "session-sotrage", title: WebInspector.UIString("Session Storage"), classes: [WebInspector.DOMStorageTreeElement], localStorage: false}];
> 
> Oops.  Just spotted these typos: "local-sotrage”, "session-sotrage"

Fixed in a follow up.

https://trac.webkit.org/r186690