Bug 146790

Summary: [Mac] Add some MediaStream files to Xcode project
Product: WebKit Reporter: Matthew Daiter <mdaiter>
Component: WebCore Misc.Assignee: Matthew Daiter <mdaiter>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, eric.carlson, jonlee, mdaiter, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar, PlatformOnly
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 146788    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Matthew Daiter
Reported 2015-07-09 09:49:14 PDT
Involves changing the WebCore.xcconfig files to make sure MediaStream Media Engine is being compiled
Attachments
Patch (7.18 KB, patch)
2015-07-22 09:38 PDT, Matthew Daiter 		no flags
DetailsFormatted DiffDiff
Patch (8.22 KB, patch)
2015-08-04 10:47 PDT, Matthew Daiter 		no flags
DetailsFormatted DiffDiff
Patch (8.22 KB, patch)
2015-08-04 11:32 PDT, Matthew Daiter 		no flags
DetailsFormatted DiffDiff
Patch (8.22 KB, patch)
2015-08-04 14:45 PDT, Matthew Daiter 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-07-09 09:50:22 PDT
<rdar://problem/21747289>
Matthew Daiter
Comment 2 2015-07-22 09:38:51 PDT
Created attachment 257278 [details] Patch
Matthew Daiter
Comment 3 2015-08-04 10:47:54 PDT
Created attachment 258183 [details] Patch
Matthew Daiter
Comment 4 2015-08-04 11:08:09 PDT
Comment on attachment 258183 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258183&action=review > Source/WebCore/platform/mediastream/MediaStreamPrivate.h:64 > + MediaStreamPrivate() { } Needed this in order to compile, minor detail about inheritance.
Matthew Daiter
Comment 5 2015-08-04 11:32:21 PDT
Created attachment 258189 [details] Patch
Matthew Daiter
Comment 6 2015-08-04 14:45:55 PDT
Created attachment 258213 [details] Patch
Eric Carlson
Comment 7 2015-08-04 14:54:45 PDT
Comment on attachment 258213 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258213&action=review > Source/WebCore/ChangeLog:3 > + Adding in MediaPrivateMediaStreamEngine to default compile Please use the bug title.
WebKit Commit Bot
Comment 8 2015-08-05 11:40:22 PDT
Comment on attachment 258213 [details] Patch Clearing flags on attachment: 258213 Committed r187971: <http://trac.webkit.org/changeset/187971>
WebKit Commit Bot
Comment 9 2015-08-05 11:40:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.