Bug 146776

Summary: Web Inspector: Checkbox disappears when unchecking CSS background style
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Test HTML Page
none
Patch
none
Patch none

Devin Rousso
Reported 2015-07-08 23:16:06 PDT
Created attachment 256461 [details] Test HTML Page Safari's web inspector CSS editor removes the checkbox on certain styles when clicked. * STEPS TO REPRODUCE 1. Open the attached HTML file (16214480.html) 2. Safari > Develop > Show Web Inspector > Inspect, click the div 3. Try unchecking each of the styles in the CSS editor, then rechecking them * RESULTS When you uncheck 'background', the checkbox you unchecked vanishes. This makes it difficult to re-enable the style. The problem does not occur with the other style ('color') Expected: checkboxes shouldn't mysteriously disappear * REGRESSION Tested on 13D11, Safari 7.0.2 * NOTES This problem does not occur in Google Chrome (tested on 33.0.1750.117), the checkboxes are always usable. Semi-workaround for Safari is to position the cursor in the /* background: ... */, and delete the leading "/*". This re-enables the style, but you have to be sure to also remove the trailing "*/".
Attachments
Test HTML Page (1.69 KB, text/html)
2015-07-08 23:16 PDT, Devin Rousso 		no flags
Details
Patch (5.79 KB, patch)
2015-07-08 23:22 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (5.73 KB, patch)
2015-07-09 11:30 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2015-07-08 23:16:20 PDT
<rdar://problem/16214480>
Devin Rousso
Comment 2 2015-07-08 23:22:08 PDT
Created attachment 256463 [details] Patch
Timothy Hatcher
Comment 3 2015-07-09 11:03:18 PDT
Comment on attachment 256463 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256463&action=review > Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:820 > + _createCommentedCheckboxMarker(lineHandler) Nit: lineHandle
Devin Rousso
Comment 4 2015-07-09 11:30:38 PDT
Created attachment 256493 [details] Patch
WebKit Commit Bot
Comment 5 2015-07-09 12:26:32 PDT
Comment on attachment 256493 [details] Patch Clearing flags on attachment: 256493 Committed r186602: <http://trac.webkit.org/changeset/186602>
WebKit Commit Bot
Comment 6 2015-07-09 12:26:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.