Bug 146770

Summary: [EFL] vibration/navigator-vibration.html failed after r186265
Product: WebKit Reporter: Hunseop Jeong <hs85.jeong>
Component: WebKit EFLAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, gyuyoung.kim, lucas.de.marchi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Update layout test none

Description Hunseop Jeong 2015-07-08 19:45:26 PDT 
Expected : 
PASS navigator.vibrate(0); is true
PASS navigator.vibrate([]); is true
PASS navigator.vibrate(1); is true
PASS navigator.vibrate([1, 2]); is true
PASS navigator.vibrate([1, 2, 3]); is true
PASS navigator.vibrate(); threw exception TypeError: Not enough arguments.
PASS navigator.vibrate([1], [2]); threw exception TypeError: Type error.
PASS successfullyParsed is true

Actual : 
PASS navigator.vibrate(0); is true
PASS navigator.vibrate([]); is true
PASS navigator.vibrate(1); is true
PASS navigator.vibrate([1, 2]); is true
PASS navigator.vibrate([1, 2, 3]); is true
PASS navigator.vibrate(); threw exception TypeError: Not enough arguments.
FAIL navigator.vibrate([1], [2]); should threw exception: Was true.
PASS successfullyParsed is true


navigator.vibrate([1], [2]); should threw typeError exception.
But it didn't threw the exception after r186265.
Comment 1 Daniel Bates 2015-07-08 20:30:35 PDT 
The new behavior is correct. We need to update the test and expected result.
Comment 2 Daniel Bates 2015-07-08 20:53:08 PDT 
Created attachment 256455 [details]
Update layout test
Comment 3 WebKit Commit Bot 2015-07-08 22:53:59 PDT 
Comment on attachment 256455 [details]
Update layout test

Clearing flags on attachment: 256455

Committed r186582: <http://trac.webkit.org/changeset/186582>
Comment 4 WebKit Commit Bot 2015-07-08 22:54:03 PDT 
All reviewed patches have been landed.  Closing bug.