| Summary: | [Cocoa] Report the first paint after committing a load as a rendering progress event | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | mitz | ||||
| Component: | WebKit2 | Assignee: | mitz | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, simon.fraser, thorton | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
mitz
2015-07-08 17:41:15 PDT
Created attachment 256441 [details]
Add _WKRenderingProgressEventFirstPaint
Comment on attachment 256441 [details] Add _WKRenderingProgressEventFirstPaint View in context: https://bugs.webkit.org/attachment.cgi?id=256441&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:975 > + _navigationState->didFirstPaint(); Will _needsResetViewStateAfterCommitLoadForMainFrame always be true in the necessary cases? Comment on attachment 256441 [details] Add _WKRenderingProgressEventFirstPaint View in context: https://bugs.webkit.org/attachment.cgi?id=256441&action=review >> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:975 >> + _navigationState->didFirstPaint(); > > Will _needsResetViewStateAfterCommitLoadForMainFrame always be true in the necessary cases? I think so? It gets set to YES when the load is committed. Do you have a specific concern? Comment on attachment 256441 [details] Add _WKRenderingProgressEventFirstPaint View in context: https://bugs.webkit.org/attachment.cgi?id=256441&action=review >>> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:975 >>> + _navigationState->didFirstPaint(); >> >> Will _needsResetViewStateAfterCommitLoadForMainFrame always be true in the necessary cases? > > I think so? It gets set to YES when the load is committed. Do you have a specific concern? Not at all, just couldn't check at the time and the name is not quite so definitive. Sounds good to me! Committed <http://trac.webkit.org/r186586>. |