Bug 146737

Summary:

Make ApplicationStateTracker be per view instead of being a singleton

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	kling: review+

Description Anders Carlsson 2015-07-08 12:41:51 PDT

Make ApplicationStateTracker be per view instead of being a singleton

Comment 1 Anders Carlsson 2015-07-08 12:43:56 PDT

Created attachment 256398 [details]
Patch

Comment 2 WebKit Commit Bot 2015-07-08 12:46:56 PDT

Attachment 256398 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ApplicationStateTracker.mm:101:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/ApplicationStateTracker.mm:126:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/ApplicationStateTracker.mm:130:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 3 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Anders Carlsson 2015-07-08 12:58:11 PDT

Created attachment 256401 [details]
Patch

Comment 4 WebKit Commit Bot 2015-07-08 12:59:59 PDT

Attachment 256401 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ApplicationStateTracker.mm:101:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/ApplicationStateTracker.mm:126:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/ApplicationStateTracker.mm:130:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 3 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 Andreas Kling 2015-07-08 13:16:52 PDT

Comment on attachment 256401 [details]
Patch

rs=me

Comment 6 Anders Carlsson 2015-07-08 13:37:12 PDT

Committed r186523: <http://trac.webkit.org/changeset/186523>