| Summary: | [Mac] Two clicks required to enable AirPlay at youtube.com | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||
| Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Eric Carlson
2015-07-08 11:13:28 PDT
Created attachment 256390 [details]
Proposed patch.
Comment on attachment 256390 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=256390&action=review r=me. I had a couple of questions about the m_targetChanged flag. > Source/WebCore/Modules/mediasession/WebMediaSessionManager.cpp:203 > // Do not take the target if another client has it and the client reporting a state change is not playing. You should revise this comment to match the code below (or get rid of it?) > Source/WebCore/Modules/mediasession/WebMediaSessionManager.cpp:283 > + state->requestedPicker = false; Do we ever need to reset the 'm_targetChanged' state? WebMediaSessionManager exists for the life of the process, right? So does that mean future changes to target won't work right? (In reply to comment #3) > Comment on attachment 256390 [details] > Proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=256390&action=review > > r=me. I had a couple of questions about the m_targetChanged flag. > > > Source/WebCore/Modules/mediasession/WebMediaSessionManager.cpp:203 > > // Do not take the target if another client has it and the client reporting a state change is not playing. > > You should revise this comment to match the code below (or get rid of it?) > Removed. > > Source/WebCore/Modules/mediasession/WebMediaSessionManager.cpp:283 > > + state->requestedPicker = false; > > Do we ever need to reset the 'm_targetChanged' state? WebMediaSessionManager > exists for the life of the process, right? So does that mean future changes > to target won't work right? > Good point, fixed. Thanks! Committed r186519: https://trac.webkit.org/r186519 |