Bug 146730

Summary:

Do not waste window server memory for placeholder windows initiated by ThemeMac.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Forms

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

InRadar

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	simon.fraser: review+

Description zalan 2015-07-08 09:41:21 PDT

Use defer:YES when initiating WebCoreThemeWindow

Comment 1 zalan 2015-07-08 09:41:56 PDT

rdar://problem/20321222

Comment 2 zalan 2015-07-08 09:46:18 PDT

Created attachment 256382 [details]
Patch

Comment 3 zalan 2015-07-08 09:49:32 PDT

Committed r186509: <http://trac.webkit.org/changeset/186509>

Comment 4 Simon Fraser (smfr) 2015-07-08 09:51:32 PDT

Comment on attachment 256382 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256382&action=review

> Source/WebCore/platform/mac/ThemeMac.mm:78
> +    // going to draw into it. The other arguments match what you get when calling -[NSWindow init].

I don't think you need the "The other arguments" bit.