Bug 146717

Summary: [GTK] Deactivate GObject bindings for static methods
Product: WebKit Reporter: Xabier Rodríguez Calvar <calvaris>
Component: WebCore JavaScriptAssignee: Xabier Rodríguez Calvar <calvaris>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bfulgham, cgarcia, commit-queue, darin, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Xabier Rodríguez Calvar 2015-07-08 02:29:03 PDT
[GTK] Deactivate GObject bindings for static methods
Comment 1 Xabier Rodríguez Calvar 2015-07-08 02:33:42 PDT
Created attachment 256366 [details]
Patch

Deactivate GObject bindings generation for static methods
Comment 2 Xabier Rodríguez Calvar 2015-07-08 02:51:58 PDT
Carlos suggested me to remove the static methods from the GObject bindings generation. I don't know if it might be interesting for the ObjC ones too. That's why I added you.
Comment 3 Xabier Rodríguez Calvar 2015-07-08 02:53:48 PDT
(In reply to comment #2)
> Carlos suggested me to remove the static methods from the GObject bindings
> generation. I don't know if it might be interesting for the ObjC ones too.
> That's why I added you.

The idea is that the implemenetation might be wrong since in the case of both GObject and ObjC the generation creates something with IMPL-> which doesn't sound right for static methods.
Comment 4 WebKit Commit Bot 2015-07-08 03:35:46 PDT
Comment on attachment 256366 [details]
Patch

Clearing flags on attachment: 256366

Committed r186496: <http://trac.webkit.org/changeset/186496>
Comment 5 WebKit Commit Bot 2015-07-08 03:35:49 PDT
All reviewed patches have been landed.  Closing bug.