Bug 146717

Summary: [GTK] Deactivate GObject bindings for static methods
Product: WebKit Reporter: Xabier Rodríguez Calvar <calvaris>
Component: WebCore JavaScriptAssignee: Xabier Rodríguez Calvar <calvaris>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bfulgham, cgarcia, commit-queue, darin, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Xabier Rodríguez Calvar
Reported 2015-07-08 02:29:03 PDT
[GTK] Deactivate GObject bindings for static methods
Attachments
Patch (9.85 KB, patch)
2015-07-08 02:33 PDT, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Xabier Rodríguez Calvar
Comment 1 2015-07-08 02:33:42 PDT
Created attachment 256366 [details] Patch Deactivate GObject bindings generation for static methods
Xabier Rodríguez Calvar
Comment 2 2015-07-08 02:51:58 PDT
Carlos suggested me to remove the static methods from the GObject bindings generation. I don't know if it might be interesting for the ObjC ones too. That's why I added you.
Xabier Rodríguez Calvar
Comment 3 2015-07-08 02:53:48 PDT
(In reply to comment #2) > Carlos suggested me to remove the static methods from the GObject bindings > generation. I don't know if it might be interesting for the ObjC ones too. > That's why I added you. The idea is that the implemenetation might be wrong since in the case of both GObject and ObjC the generation creates something with IMPL-> which doesn't sound right for static methods.
WebKit Commit Bot
Comment 4 2015-07-08 03:35:46 PDT
Comment on attachment 256366 [details] Patch Clearing flags on attachment: 256366 Committed r186496: <http://trac.webkit.org/changeset/186496>
WebKit Commit Bot
Comment 5 2015-07-08 03:35:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.