Bug 146702

Summary: Add actions to image previews
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, enrica, sam, thorton, yongjun_zhang
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch sam: review+

Description Beth Dakin 2015-07-07 16:26:25 PDT
Add actions to image previews

<rdar://problem/21642654>
Comment 1 Beth Dakin 2015-07-07 16:35:37 PDT
Created attachment 256332 [details]
Patch
Comment 2 WebKit Commit Bot 2015-07-07 16:38:27 PDT
Attachment 256332 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WKImagePreviewViewController.mm:31:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:309:  The parameter name "!" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Beth Dakin 2015-07-07 17:33:51 PDT
Created attachment 256337 [details]
Patch
Comment 4 WebKit Commit Bot 2015-07-07 17:35:56 PDT
Attachment 256337 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:309:  The parameter name "!" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Yongjun Zhang 2015-07-08 10:43:36 PDT
Comment on attachment 256337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256337&action=review

> Source/WebKit2/UIProcess/WKImagePreviewViewController.h:38
> +    _WKActivatedElementInfo *_activatedElementInfo;

I think we should retain the _activeElementInfo.

> Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:298
> +    NSURL *targetURL = [NSURL URLWithString:positionInformation.url];

Nit: Could we use _web_URLWithWTFString: here?

The patch looks good to me, I will let a WebKit reviewer to comment.
Comment 6 Beth Dakin 2015-07-08 10:44:31 PDT
(In reply to comment #5)
> Comment on attachment 256337 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256337&action=review
> 
> > Source/WebKit2/UIProcess/WKImagePreviewViewController.h:38
> > +    _WKActivatedElementInfo *_activatedElementInfo;
> 
> I think we should retain the _activeElementInfo.
> 

Will do.

> > Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:298
> > +    NSURL *targetURL = [NSURL URLWithString:positionInformation.url];
> 
> Nit: Could we use _web_URLWithWTFString: here?
> 

Yes!

> The patch looks good to me, I will let a WebKit reviewer to comment.
Comment 7 Beth Dakin 2015-07-08 11:00:38 PDT
Thanks all! http://trac.webkit.org/changeset/186515