Bug 146702

Summary: Add actions to image previews
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, enrica, sam, thorton, yongjun_zhang
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch sam: review+

Beth Dakin
Reported 2015-07-07 16:26:25 PDT
Add actions to image previews <rdar://problem/21642654>
Attachments
Patch (9.59 KB, patch)
2015-07-07 16:35 PDT, Beth Dakin 		no flags
DetailsFormatted DiffDiff
Patch (9.78 KB, patch)
2015-07-07 17:33 PDT, Beth Dakin 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2015-07-07 16:35:37 PDT
Created attachment 256332 [details] Patch
WebKit Commit Bot
Comment 2 2015-07-07 16:38:27 PDT
Attachment 256332 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/WKImagePreviewViewController.mm:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:309: The parameter name "!" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Beth Dakin
Comment 3 2015-07-07 17:33:51 PDT
Created attachment 256337 [details] Patch
WebKit Commit Bot
Comment 4 2015-07-07 17:35:56 PDT
Attachment 256337 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:309: The parameter name "!" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yongjun Zhang
Comment 5 2015-07-08 10:43:36 PDT
Comment on attachment 256337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256337&action=review > Source/WebKit2/UIProcess/WKImagePreviewViewController.h:38 > + _WKActivatedElementInfo *_activatedElementInfo; I think we should retain the _activeElementInfo. > Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:298 > + NSURL *targetURL = [NSURL URLWithString:positionInformation.url]; Nit: Could we use _web_URLWithWTFString: here? The patch looks good to me, I will let a WebKit reviewer to comment.
Beth Dakin
Comment 6 2015-07-08 10:44:31 PDT
(In reply to comment #5) > Comment on attachment 256337 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=256337&action=review > > > Source/WebKit2/UIProcess/WKImagePreviewViewController.h:38 > > + _WKActivatedElementInfo *_activatedElementInfo; > > I think we should retain the _activeElementInfo. > Will do. > > Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:298 > > + NSURL *targetURL = [NSURL URLWithString:positionInformation.url]; > > Nit: Could we use _web_URLWithWTFString: here? > Yes! > The patch looks good to me, I will let a WebKit reviewer to comment.
Beth Dakin
Comment 7 2015-07-08 11:00:38 PDT
Thanks all! http://trac.webkit.org/changeset/186515
Note You need to log in before you can comment on or make changes to this bug.