Bug 146691

Summary:

Web Inspector: Details sidebar doesn't activate on first selected resource in Network tab

Product:

WebKit

Reporter:

Jon Davis <jond>

Component:

Web Inspector

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Mac (Intel)

OS:

All

Attachments:

Description	Flags
Shows disabled sidebar icon, and reluctance of sidebar to open.	none
Patch	none

Jon Davis

Reported 2015-07-07 12:57:39 PDT

The sidebar icon remains in a disabled state in the Network tab even after selecting a resource. The second selection of a resource activates the sidebar icon. Additionally, after reloading, clicking the sidebar icon before selecting a resource does nothing. Then when you select a resource, the sidebar opens with the resource. If the sidebar icon is disabled, it shouldn't toggle anything to open. However, I think it should always be clickable and if no resource selection exists, the main document should auto-select and open the sidebar.

Attachments
Shows disabled sidebar icon, and reluctance of sidebar to open. (1.15 MB, video/mp4) 2015-07-07 14:03 PDT, Jon Davis	no flags	Details
Patch (6.55 KB, patch) 2015-07-08 14:46 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-07-07 12:57:55 PDT

<rdar://problem/21709833>

Timothy Hatcher

Comment 2 2015-07-07 13:15:36 PDT

I wonder if there is an exception that is causing this. Can you inspect the inspector to check? http://trac.webkit.org/wiki/WebInspectorDebugging

Jon Davis

Comment 3 2015-07-07 14:03:48 PDT

Created attachment 256321 [details] Shows disabled sidebar icon, and reluctance of sidebar to open. I could not get the second behavior to repro in this video. Clicking the sidebar icon with no resource selected, then selecting the resource does not open the sidebar as it did when I was first noticing the behavior.

Timothy Hatcher

Comment 4 2015-07-08 14:46:34 PDT

Created attachment 256406 [details] Patch

Joseph Pecoraro

Comment 5 2015-07-08 16:22:41 PDT

Comment on attachment 256406 [details] Patch r=me

WebKit Commit Bot

Comment 6 2015-07-08 16:55:23 PDT

Comment on attachment 256406 [details] Patch Clearing flags on attachment: 256406 Committed r186540: <http://trac.webkit.org/changeset/186540>

WebKit Commit Bot

Comment 7 2015-07-08 16:55:26 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.