Bug 146691

Summary: Web Inspector: Details sidebar doesn't activate on first selected resource in Network tab
Product: WebKit Reporter: Jon Davis <jond>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: All   
Attachments:
Description Flags
Shows disabled sidebar icon, and reluctance of sidebar to open.
none
Patch none

Description Jon Davis 2015-07-07 12:57:39 PDT
The sidebar icon remains in a disabled state in the Network tab even after selecting a resource. The second selection of a resource activates the sidebar icon. Additionally, after reloading, clicking the sidebar icon before selecting a resource does nothing. Then when you select a resource, the sidebar opens with the resource.

If the sidebar icon is disabled, it shouldn't toggle anything to open. However, I think it should always be clickable and if no resource selection exists, the main document should auto-select and open the sidebar.
Comment 1 Radar WebKit Bug Importer 2015-07-07 12:57:55 PDT
<rdar://problem/21709833>
Comment 2 Timothy Hatcher 2015-07-07 13:15:36 PDT
I wonder if there is an exception that is causing this. Can you inspect the inspector to check? http://trac.webkit.org/wiki/WebInspectorDebugging
Comment 3 Jon Davis 2015-07-07 14:03:48 PDT
Created attachment 256321 [details]
Shows disabled sidebar icon, and reluctance of sidebar to open.

I could not get the second behavior to repro in this video. Clicking the sidebar icon with no resource selected, then selecting the resource does not open the sidebar as it did when I was first noticing the behavior.
Comment 4 Timothy Hatcher 2015-07-08 14:46:34 PDT
Created attachment 256406 [details]
Patch
Comment 5 Joseph Pecoraro 2015-07-08 16:22:41 PDT
Comment on attachment 256406 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2015-07-08 16:55:23 PDT
Comment on attachment 256406 [details]
Patch

Clearing flags on attachment: 256406

Committed r186540: <http://trac.webkit.org/changeset/186540>
Comment 7 WebKit Commit Bot 2015-07-08 16:55:26 PDT
All reviewed patches have been landed.  Closing bug.