Bug 146681

Summary: Bring back the GNU ar check to create thin archives on non-Linux systems
Product: WebKit Reporter: Ting-Wei Lan <lantw44>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, commit-queue, dbates, gyuyoung.kim, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Ting-Wei Lan
Reported 2015-07-07 06:30:56 PDT
We used 'ar -V' to check whether we are using GNU ar and add the T (thin archive) flag if GNU ar is used when we still had autotools build. It was added in https://bugs.webkit.org/show_bug.cgi?id=128596. However, autotools build was removed, and we use '${CMAKE_SYSTEM_NAME} STREQUAL "Linux"' to do the GNU ar check instead in cmake build, which means all non-Linux systems cannot use GNU ar thin archive feature. This means getting debug build of WebKit on *BSD or other non-Linux systems can be hard because WebCore static archive can be larger than 4 GiB and cause error: https://bugs.webkit.org/show_bug.cgi?id=140384. GNU ar thin archive feature is really needed to prevent the error. After applying the attached patch and modifying some environment variables, I can get a debug build of WebKitGTK+ on FreeBSD now.
Attachments
Patch (1.81 KB, patch)
2015-07-07 06:33 PDT, Ting-Wei Lan 		no flags
DetailsFormatted DiffDiff
Patch (1.86 KB, patch)
2015-07-16 00:56 PDT, Ting-Wei Lan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ting-Wei Lan
Comment 1 2015-07-07 06:33:11 PDT
Created attachment 256296 [details] Patch
Ting-Wei Lan
Comment 2 2015-07-16 00:56:08 PDT
Created attachment 256895 [details] Patch
WebKit Commit Bot
Comment 3 2015-07-17 23:33:58 PDT
Comment on attachment 256895 [details] Patch Clearing flags on attachment: 256895 Committed r186987: <http://trac.webkit.org/changeset/186987>
WebKit Commit Bot
Comment 4 2015-07-17 23:34:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.