Bug 146678

Summary: [GTK] Fix rsvg build due to missing libcroco dependency
Product: WebKit Reporter: Emanuele Aina <emanuele.aina>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: mcatanzaro, mrobinson
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 145696    
Attachments:
Description Flags
Patch mrobinson: review-

Description Emanuele Aina 2015-07-07 01:27:07 PDT 
The jhbuild moduleset currently fails due to librsvg needing libcroco.
Comment 1 Emanuele Aina 2015-07-07 01:31:10 PDT 
Created attachment 256291 [details]
Patch
Comment 2 Martin Robinson 2015-07-07 10:10:16 PDT 
Comment on attachment 256291 [details]
Patch

We currently reserve the JHBuild for dependencies that actually affect test results. Other dependencies should be added to Tools/gtk/install-dependencies.
Comment 3 Emanuele Aina 2015-07-08 01:14:43 PDT 
Oh, got it, and libcroco is already listed there. Sorry for the noise, thanks!
Comment 4 Michael Catanzaro 2015-07-08 07:54:05 PDT 
Let me repurpose this bug slightly. I want install-dependencies to be used only for software that does not depend on anything we build in jhbuild. libcroco should be built by jhbuild because it depends on glib.
Comment 5 Martin Robinson 2015-07-08 08:03:26 PDT 
I think there is definitely a value in keeping the JHBuild moduleset as small as possible. WebKit developers shouldn't have to build the entire world.
Comment 6 Michael Catanzaro 2015-07-08 08:07:23 PDT 
Let's discuss in bug #145696.
Comment 7 Michael Catanzaro 2015-07-08 12:51:05 PDT 
We agreed to only add these dependencies to jhbuild as problems arise, at least for now. Hopefully there are few issues in practice.