Bug 146675

Summary: REGRESSION (r185629): Web Inspector: Filtering doesn't display any items if folders are used to organize the web page resources
Product: WebKit Reporter: Tobias Reiss <tobi+webkit>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar, Regression
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Video that shows bug where Resources are not filtered
none
Patch none

Tobias Reiss
Reported 2015-07-06 23:44:50 PDT
Created attachment 256281 [details] Video that shows bug where Resources are not filtered - go to sz.de - click on Resources Tab ("All Resources" must be pre-selected) - click on "Documents" and select "StyleSheets" from Dropdown menu IS: "No filter results" EXPECTED: show filter results This bug is not related to a specific Website, but it's harder to reproduce for Websites that had been already opened before. It seems the Resources are not "available/initialized" yet, as the Filter action appears.
Attachments
Video that shows bug where Resources are not filtered (2.58 MB, video/quicktime)
2015-07-06 23:44 PDT, Tobias Reiss
no flags
Patch (4.00 KB, patch)
2015-07-08 08:20 PDT, Timothy Hatcher
no flags
Radar WebKit Bug Importer
Comment 1 2015-07-06 23:45:08 PDT
Timothy Hatcher
Comment 2 2015-07-07 11:07:43 PDT
Timothy Hatcher
Comment 3 2015-07-07 13:43:25 PDT
Text filtering in filters is broken too. This regressed because: http://trac.webkit.org/changeset/185629/trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js Which regressed because of: http://trac.webkit.org/changeset/171645/trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js I plan to revert r185629. I'll then consider a better for r171645.
Timothy Hatcher
Comment 4 2015-07-08 08:20:58 PDT
Joseph Pecoraro
Comment 5 2015-07-08 11:38:27 PDT
Comment on attachment 256375 [details] Patch r=me, this is pretty complex now with all these booleans =(
WebKit Commit Bot
Comment 6 2015-07-08 12:28:51 PDT
Comment on attachment 256375 [details] Patch Clearing flags on attachment: 256375 Committed r186520: <http://trac.webkit.org/changeset/186520>
WebKit Commit Bot
Comment 7 2015-07-08 12:28:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.