Bug 146674

Summary: AX: VoiceOver cannot get to any content in Yahoo Mail messages table
Product: WebKit Reporter: chris fleizach <cfleizach>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, bfulgham, commit-queue, dmazzoni, jcraig, jdiggs, mario, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
patch none

Description chris fleizach 2015-07-06 23:35:49 PDT 
VoiceOver cannot get to any content in Yahoo Mail messages table

WebKit is exposing some presentational elements as AXGroup. These are in between the AXTable and AXRows.

<rdar://problem/21405928>
Comment 1 chris fleizach 2015-07-06 23:40:21 PDT 
Created attachment 256280 [details]
patch
Comment 2 WebKit Commit Bot 2015-07-06 23:43:22 PDT 
Attachment 256280 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:27:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 chris fleizach 2015-07-06 23:47:46 PDT 
Created attachment 256282 [details]
patch
Comment 4 WebKit Commit Bot 2015-07-09 00:32:33 PDT 
Comment on attachment 256282 [details]
patch

Clearing flags on attachment: 256282

Committed r186587: <http://trac.webkit.org/changeset/186587>
Comment 5 WebKit Commit Bot 2015-07-09 00:32:36 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Brent Fulgham 2015-07-09 11:11:33 PDT 
This created two new test failures on Windows. Can you take a look?
Comment 7 chris fleizach 2015-07-09 11:15:35 PDT 
(In reply to comment #6)
> This created two new test failures on Windows. Can you take a look?

I see the test that was part of this patch is failing


 test 	results	image results	actual failure	expected failure	history
+accessibility/aria-table-with-presentational-elements.html	expected actual diff pretty diff	

that's because the DRT methods are not implemented on windows, so we should skip that test (i'll do that now)

what's the other failing test?
Comment 8 Brent Fulgham 2015-07-09 11:17:37 PDT 
(In reply to comment #7)
> (In reply to comment #6)
> > This created two new test failures on Windows. Can you take a look?
> 
> I see the test that was part of this patch is failing
> 
> 
>  test 	results	image results	actual failure	expected failure	history
> +accessibility/aria-table-with-presentational-elements.html	expected actual
> diff pretty diff	
> 
> that's because the DRT methods are not implemented on windows, so we should
> skip that test (i'll do that now)
> 
> what's the other failing test?

Sorry -- the other test failure is not related to you. Please just skip the test.

Thanks!
Comment 9 chris fleizach 2015-07-09 12:06:03 PDT 
(In reply to comment #7)
> (In reply to comment #6)
> > This created two new test failures on Windows. Can you take a look?
> 
> I see the test that was part of this patch is failing
> 
> 
>  test 	results	image results	actual failure	expected failure	history
> +accessibility/aria-table-with-presentational-elements.html	expected actual
> diff pretty diff	
> 
> that's because the DRT methods are not implemented on windows, so we should
> skip that test (i'll do that now)
> 
> what's the other failing test?

http://trac.webkit.org/changeset/186595