Bug 146671

Summary:

Web Inspector: Unnecessary space added after -webkit- prefixed property values

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Actual	none
Patch	none
Video of Current Functionality	none
Patch	none
Patch	none
Patch	none

Devin Rousso

Reported 2015-07-06 23:01:27 PDT

Created attachment 256273 [details] Actual * STEPS TO REPRODUCE 1. Add the following CSS to any rule in the sidebar: width: -webkit-calc(1px); 2. After clicking outside of that rule (to remove focus), the CSS will be reformatted as: width: -webkit- calc(1px);a

Attachments
Actual (20.63 KB, image/png) 2015-07-06 23:01 PDT, Devin Rousso	no flags	Details
Patch (1.56 KB, patch) 2015-07-06 23:07 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Video of Current Functionality (741.24 KB, video/quicktime) 2015-07-07 00:37 PDT, Devin Rousso	no flags	Details
Patch (4.10 KB, patch) 2015-07-07 01:17 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (4.12 KB, patch) 2015-07-07 13:15 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (4.07 KB, patch) 2015-07-07 13:20 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-07-06 23:02:00 PDT

<rdar://problem/21698881>

Devin Rousso

Comment 2 2015-07-06 23:07:47 PDT

Created attachment 256274 [details] Patch

Joseph Pecoraro

Comment 3 2015-07-06 23:15:30 PDT

Comment on attachment 256274 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256274&action=review r-, we should add a test for this. Source/WebInspectorUI/Tools/PrettyPrinting/css-rule-tests Why don't I see it happen on this when I load the test case? Source/WebInspectorUI/Tools/PrettyPrinting/index.html?mode=css-rule&content=width%3A%20-webkit-calc(1px)%3B > Source/WebInspectorUI/ChangeLog:9 > + * UserInterface/Views/CodeMirrorFormatters.js: Now only adds a space if both the current and previous tokens are a property, value, > + or atom. Gross formatting! Wrap a little earlier so this is more comfortable to read.

Devin Rousso

Comment 4 2015-07-07 00:37:56 PDT

Created attachment 256287 [details] Video of Current Functionality This is what is currently happening on my release build.

Devin Rousso

Comment 5 2015-07-07 01:17:51 PDT

Created attachment 256289 [details] Patch

Devin Rousso

Comment 6 2015-07-07 13:15:38 PDT

Created attachment 256316 [details] Patch

Joseph Pecoraro

Comment 7 2015-07-07 13:17:50 PDT

Comment on attachment 256316 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256316&action=review r=me, thanks for addressing all my comments! > Source/WebInspectorUI/Tools/PrettyPrinting/index.html:54 > + // Here, the "calc" keyword is added to allow the do-not-add-whitespace-before-prefixed-property-value Nit: Double space. Also don't call out a particular test by name, that is the kind of comment that can go stale in the future if that test gets removed or renamed. Just mention its to behave more like the frontend.

Devin Rousso

Comment 8 2015-07-07 13:20:20 PDT

Created attachment 256317 [details] Patch

WebKit Commit Bot

Comment 9 2015-07-07 14:22:41 PDT

Comment on attachment 256317 [details] Patch Clearing flags on attachment: 256317 Committed r186477: <http://trac.webkit.org/changeset/186477>

WebKit Commit Bot

Comment 10 2015-07-07 14:22:46 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.