Bug 146670

Summary:

Cleanup: Make ContentSecurityPolicy::ReportingStatus an enum class

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebCore Misc.

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin, ggaren, mkwst

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Daniel Bates 2015-07-06 21:29:56 PDT

We should make calling the various CSP allow* functions less error prone. One idea is to make ContentSecurityPolicy::ReportingStatus an enum class so as to prevent implicit conversion to an integral value (as implied in the fix for <https://trac.webkit.org/changeset/186395>).

Comment 1 Daniel Bates 2015-07-07 09:51:00 PDT

Created attachment 256303 [details]
Patch

I'm open to suggestions on how we can make using the various ContentSecurityPolicy::allow* functions less error prone.

Comment 2 Daniel Bates 2015-07-08 21:11:08 PDT

Comment on attachment 256303 [details]
Patch

Clearing flags on attachment: 256303

Committed r186574: <http://trac.webkit.org/changeset/186574>

Comment 3 Daniel Bates 2015-07-08 21:11:14 PDT

All reviewed patches have been landed.  Closing bug.