Bug 146670 - Cleanup: Make ContentSecurityPolicy::ReportingStatus an enum class
Summary: Cleanup: Make ContentSecurityPolicy::ReportingStatus an enum class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-06 21:29 PDT by Daniel Bates
Modified: 2015-07-08 21:11 PDT (History)
4 users (show)

See Also:

Attachments
Patch (22.62 KB, patch)
2015-07-07 09:51 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2015-07-06 21:29:56 PDT 
We should make calling the various CSP allow* functions less error prone. One idea is to make ContentSecurityPolicy::ReportingStatus an enum class so as to prevent implicit conversion to an integral value (as implied in the fix for <https://trac.webkit.org/changeset/186395>).
Comment 1 Daniel Bates 2015-07-07 09:51:00 PDT 
Created attachment 256303 [details]
Patch

I'm open to suggestions on how we can make using the various ContentSecurityPolicy::allow* functions less error prone.
Comment 2 Daniel Bates 2015-07-08 21:11:08 PDT 
Comment on attachment 256303 [details]
Patch

Clearing flags on attachment: 256303

Committed r186574: <http://trac.webkit.org/changeset/186574>
Comment 3 Daniel Bates 2015-07-08 21:11:14 PDT 
All reviewed patches have been landed.  Closing bug.