RESOLVED FIXED 146670
Cleanup: Make ContentSecurityPolicy::ReportingStatus an enum class 
https://bugs.webkit.org/show_bug.cgi?id=146670
Summary Cleanup: Make ContentSecurityPolicy::ReportingStatus an enum class
Daniel Bates
Reported 2015-07-06 21:29:56 PDT
We should make calling the various CSP allow* functions less error prone. One idea is to make ContentSecurityPolicy::ReportingStatus an enum class so as to prevent implicit conversion to an integral value (as implied in the fix for <https://trac.webkit.org/changeset/186395>).
Attachments
Patch (22.62 KB, patch)
2015-07-07 09:51 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2015-07-07 09:51:00 PDT
Created attachment 256303 [details] Patch I'm open to suggestions on how we can make using the various ContentSecurityPolicy::allow* functions less error prone.
Daniel Bates
Comment 2 2015-07-08 21:11:08 PDT
Comment on attachment 256303 [details] Patch Clearing flags on attachment: 256303 Committed r186574: <http://trac.webkit.org/changeset/186574>
Daniel Bates
Comment 3 2015-07-08 21:11:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.