Bug 146648

Summary:

Remove unused "m_isPrivate" flag on NetworkStorageSession

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebCore Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch v1	none

Brady Eidson

Reported 2015-07-06 11:38:09 PDT

Remove unused "m_isPrivate" flag on NetworkStorageSession

Attachments
Patch v1 (3.66 KB, patch) 2015-07-06 11:39 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2015-07-06 11:39:00 PDT

Created attachment 256225 [details] Patch v1

Alex Christensen

Comment 2 2015-07-06 11:40:32 PDT

lgtm, but why is this now unused?

Brady Eidson

Comment 3 2015-07-06 11:55:24 PDT

(In reply to comment #2) > lgtm, but why is this now unused? I don't know. I didn't search for the last time it was used. I just grepp'ed all of Source/ and found it's definitely unused now. And all I know is that right now its existence is in my way. :)

WebKit Commit Bot

Comment 4 2015-07-06 12:46:28 PDT

Comment on attachment 256225 [details] Patch v1 Clearing flags on attachment: 256225 Committed r186369: <http://trac.webkit.org/changeset/186369>

WebKit Commit Bot

Comment 5 2015-07-06 12:46:32 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.