Bug 14661

Summary: [s60] Some input format doesn't work properly
Product: WebKit Reporter: Rasvan Alexandrescu <rasvan.alexandrescu>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: CLOSED FIXED    
Severity: Normal    
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: S60 Hardware   
OS: S60 3rd edition   
Attachments:
Description Flags
added style format functionality to text edit
zalan: review-
modified as per comments zalan: review+

Description Rasvan Alexandrescu 2007-07-18 10:53:45 PDT
[s60] Some input format doesn't work properly.
Comment 1 Rasvan Alexandrescu 2007-07-18 11:07:37 PDT
Created attachment 15563 [details]
added style format functionality to text edit
Comment 2 zalan 2007-07-19 13:47:11 PDT
Comment on attachment 15563 [details]
added style format functionality to text edit 

the patch looks good. there is a tiny coding conventional issue in the following line
+    TBool aIsEmptyOk (!aInputRequired);

and actually, i'm not sure if this line is needed at all.
Comment 3 Rasvan Alexandrescu 2007-07-20 06:38:18 PDT
Created attachment 15598 [details]
modified as per comments
Comment 4 zalan 2007-07-20 09:55:28 PDT
Comment on attachment 15598 [details]
modified as per comments

r=me
Comment 5 zalan 2007-07-20 09:55:58 PDT
r24482 -> ccb
Comment 6 Bradley Morrison 2008-04-09 11:39:24 PDT
Bulk closing of all s60 platform bugs. 

Sorry for the noise!