| Summary: | Web Inspector: Cached resources are missing startTime and size in Network timeline | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||
| Component: | Web Inspector | Assignee: | Timothy Hatcher <timothy> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Timothy Hatcher
2015-07-04 07:28:57 PDT
Created attachment 256143 [details]
Patch
Comment on attachment 256143 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256143&action=review r=me! > Source/WebInspectorUI/ChangeLog:11 > + * UserInterface/Controllers/FrameResourceManager.js: > + (WebInspector.FrameResourceManager.prototype.resourceRequestWasServedFromMemoryCache): Pass elapsedTime in the right argument order. > + Add missing calls to Resource.increaseSize and Resource.increaseTransferSize. > + (WebInspector.FrameResourceManager.prototype.resourceRequestDidReceiveResponse): Pass elapsedTime in the right argument order. Yikes. Good catch! > Source/WebInspectorUI/UserInterface/Controllers/FrameResourceManager.js:237 > + var resource = this._addNewResourceToFrame(requestIdentifier, frameIdentifier, loaderIdentifier, cachedResourcePayload.url, cachedResourcePayload.type, "GET", null, null, elapsedTime, null, null, initiatorSourceCodeLocation); I wonder if this could have been anything but GET. Comment on attachment 256143 [details] Patch Clearing flags on attachment: 256143 Committed r186303: <http://trac.webkit.org/changeset/186303> All reviewed patches have been landed. Closing bug. |