Bug 146600

Summary:

[Win] Remove "!!" operators placed in front of RegisterClassEx() calls

Product:

WebKit

Reporter:

Sungmann Cho <sungmann.cho>

Component:

WebKit Misc.

Assignee:

Sungmann Cho <sungmann.cho>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Sungmann Cho 2015-07-03 17:09:29 PDT

SSIA

Comment 1 Sungmann Cho 2015-07-03 17:13:31 PDT

Created attachment 256124 [details]
Patch

Comment 2 Chris Dumez 2015-07-03 17:24:10 PDT

Comment on attachment 256124 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256124&action=review

> Source/WebKit/win/ChangeLog:3
> +        [Win] Remove "!!" operators placed in front of RegisterClassEx() calls.

Why? Although the !! is not technically needed, it makes it clear / explicit that we are converting a return value that is not a boolean (ATOM) into a boolean.

Comment 3 Sungmann Cho 2015-07-03 17:36:41 PDT

Oops. You are right. Thank you for pointing that out! Close the issue.

Comment 4 Gyuyoung Kim 2015-07-04 03:52:17 PDT

Comment on attachment 256124 [details]
Patch

Clearing review / commit-queue requests.