Bug 146584

Summary: Add new sources to StyleAllInOne.cpp
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, esprehn+autocc, glenn, kondapallykalyan, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 102647    
Attachments:
Description Flags
Patch
none
Patch
none
Patch bfulgham: review+

Description Csaba Osztrogonác 2015-07-03 03:25:25 PDT 
The following sources aren't added to StyleAllInOne.cpp yet:
BasicShapes.cpp
GridResolvedPosition.cpp
ShapeValue.cpp

Additionally we can remove useless ifdef guard from StyleAllInOne.cpp,
StyleGridData.cpp, StyleGridItemData.cpp and StyleScrollSnapPoints.cpp
sources are properly guarded, we don't need duplicated guards.
Comment 1 Csaba Osztrogonác 2015-07-03 03:26:23 PDT 
Created attachment 256091 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-07-06 00:06:37 PDT 
Created attachment 256194 [details]
Patch

Let's see the Windows EWS aqain, maybe it is in better shape.
Comment 3 Csaba Osztrogonác 2015-07-07 10:03:06 PDT 
Created attachment 256305 [details]
Patch

one more shot for the Windows EWS
Comment 4 Brent Fulgham 2015-07-08 14:14:10 PDT 
Comment on attachment 256305 [details]
Patch

r=me
Comment 5 Brent Fulgham 2015-07-08 14:39:14 PDT 
Committed r186528: <http://trac.webkit.org/changeset/186528>