Bug 146584

Summary: Add new sources to StyleAllInOne.cpp
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, esprehn+autocc, glenn, kondapallykalyan, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 102647    
Attachments:
Description Flags
Patch
none
Patch
none
Patch bfulgham: review+

Csaba Osztrogonác
Reported 2015-07-03 03:25:25 PDT
The following sources aren't added to StyleAllInOne.cpp yet: BasicShapes.cpp GridResolvedPosition.cpp ShapeValue.cpp Additionally we can remove useless ifdef guard from StyleAllInOne.cpp, StyleGridData.cpp, StyleGridItemData.cpp and StyleScrollSnapPoints.cpp sources are properly guarded, we don't need duplicated guards.
Attachments
Patch (8.53 KB, patch)
2015-07-03 03:26 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (8.55 KB, patch)
2015-07-06 00:06 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (8.54 KB, patch)
2015-07-07 10:03 PDT, Csaba Osztrogonác 		bfulgham: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2015-07-03 03:26:23 PDT
Created attachment 256091 [details] Patch
Csaba Osztrogonác
Comment 2 2015-07-06 00:06:37 PDT
Created attachment 256194 [details] Patch Let's see the Windows EWS aqain, maybe it is in better shape.
Csaba Osztrogonác
Comment 3 2015-07-07 10:03:06 PDT
Created attachment 256305 [details] Patch one more shot for the Windows EWS
Brent Fulgham
Comment 4 2015-07-08 14:14:10 PDT
Comment on attachment 256305 [details] Patch r=me
Brent Fulgham
Comment 5 2015-07-08 14:39:14 PDT
Committed r186528: <http://trac.webkit.org/changeset/186528>
Note You need to log in before you can comment on or make changes to this bug.