| Summary: | Captions' highlights do not entirely cover their constituent text | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||
| Status: | NEW --- | ||||||||
| Severity: | Normal | CC: | dino, eric.carlson, jonlee, simon.fraser, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Myles C. Maxfield
2015-07-02 18:15:42 PDT
Created attachment 256064 [details]
Patch
Created attachment 256065 [details]
Patch
Comment on attachment 256065 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256065&action=review > Source/WebCore/ChangeLog:18 > + fallback metrics of its contents. This property, however, requires that the > + span be turned into a div (which is fine because these elements are internal > + to WebKit). Is this OK? Is there ever more than one on a line? Comment on attachment 256065 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256065&action=review >> Source/WebCore/ChangeLog:18 >> + to WebKit). > > Is this OK? Is there ever more than one on a line? There is never more than one in a row. See VTTCue::getDisplayTree(). This actually changes behavior if the text line-wraps. Hyatt says that line-box-contain should work on inline elements. I need to figure out why it didn't seem to work for me earlier. Comment on attachment 256065 [details]
Patch
r- then!
line-box-contain only grows the root line box. It doesn't grow the inlineflowboxes which are the things which paint the background. hyatt says "honestly if you have a fix that works pretty well, i’d just leave this alone" |