| Summary: | REGRESSION (r178097): HTMLSelectElement.add(option, undefined) prepends option to the list of options; should append to the end of the list of options | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||||||||
| Component: | WebCore Misc. | Assignee: | Chris Dumez <cdumez> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | buildbot, cdumez, commit-queue, darin, gyuyoung.kim, mitz, rniwa, sam, shiva.jm, webkit-bug-importer | ||||||||||||
| Priority: | P1 | Keywords: | InRadar, Regression | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | All | ||||||||||||||
| OS: | All | ||||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=146515 | ||||||||||||||
| Bug Depends on: | 139179 | ||||||||||||||
| Bug Blocks: | |||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Daniel Bates
2015-07-02 17:41:32 PDT
Created attachment 256056 [details]
Example
Relevant specs: https://html.spec.whatwg.org/multipage/forms.html#dom-select-add which points to: https://html.spec.whatwg.org/multipage/infrastructure.html#dom-htmloptionscollection-add which says in this case to call the DOM insertBefore() method on the parent node, with element as the first argument and null (in our case) as the second argument. https://dom.spec.whatwg.org/#dom-node-insertbefore -> https://dom.spec.whatwg.org/#concept-node-insert " For each newNode in nodes, in tree order, run these substeps: 1. Insert newNode into parent before child or at the end of parent if child is null. 2. Run the insertion steps with newNode. " Ok, so even though it is hard to follow, the spec does say to insert "at the end of parent if child is null". Created attachment 256114 [details]
Patch
Created attachment 256120 [details]
Patch
Comment on attachment 256120 [details] Patch Attachment 256120 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4714810553925632 New failing tests: fast/dom/HTMLSelectElement/add.html Created attachment 256122 [details]
Archive of layout-test-results from ews102 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5
Created attachment 256123 [details]
Patch
Comment on attachment 256123 [details] Patch Clearing flags on attachment: 256123 Committed r186275: <http://trac.webkit.org/changeset/186275> All reviewed patches have been landed. Closing bug. |