Bug 146566

Summary:

REGRESSION (r178097): HTMLSelectElement.add(option, undefined) prepends option to the list of options; should append to the end of the list of options

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebCore Misc.

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, commit-queue, darin, gyuyoung.kim, mitz, rniwa, sam, shiva.jm, webkit-bug-importer

Priority:

Keywords:

InRadar, Regression

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=146515

Bug Depends on:

139179

Bug Blocks:

Attachments:

Description	Flags
Example	none
Patch	none
Patch	none
Archive of layout-test-results from ews102 for mac-mavericks	none
Patch	none

Daniel Bates

Reported 2015-07-02 17:41:32 PDT

Following the change made in bug #139179 (http://trac.webkit.org/changeset/178097), calling HTMLSelectElement.add(O, undefined) prepends O to the list of options where O is either an HTML option element or an HTML optgroup element. But it should append O to the end of the list of options.

Attachments
Example (585 bytes, text/html) 2015-07-02 17:45 PDT, Daniel Bates	no flags	Details
Patch (21.50 KB, patch) 2015-07-03 11:22 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (20.68 KB, patch) 2015-07-03 14:03 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-mavericks (535.31 KB, application/zip) 2015-07-03 14:42 PDT, Build Bot	no flags	Details
Patch (21.56 KB, patch) 2015-07-03 14:44 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2015-07-02 17:45:56 PDT

Created attachment 256056 [details] Example

Radar WebKit Bug Importer

Comment 2 2015-07-02 17:49:42 PDT

<rdar://problem/21663919>

Chris Dumez

Comment 3 2015-07-02 20:18:57 PDT

Relevant specs: https://html.spec.whatwg.org/multipage/forms.html#dom-select-add which points to: https://html.spec.whatwg.org/multipage/infrastructure.html#dom-htmloptionscollection-add which says in this case to call the DOM insertBefore() method on the parent node, with element as the first argument and null (in our case) as the second argument. https://dom.spec.whatwg.org/#dom-node-insertbefore -> https://dom.spec.whatwg.org/#concept-node-insert " For each newNode in nodes, in tree order, run these substeps: 1. Insert newNode into parent before child or at the end of parent if child is null. 2. Run the insertion steps with newNode. " Ok, so even though it is hard to follow, the spec does say to insert "at the end of parent if child is null".

Chris Dumez

Comment 4 2015-07-03 11:22:48 PDT

Created attachment 256114 [details] Patch

Chris Dumez

Comment 5 2015-07-03 14:03:32 PDT

Created attachment 256120 [details] Patch

Build Bot

Comment 6 2015-07-03 14:42:47 PDT

Comment on attachment 256120 [details] Patch Attachment 256120 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4714810553925632 New failing tests: fast/dom/HTMLSelectElement/add.html

Build Bot

Comment 7 2015-07-03 14:42:50 PDT

Created attachment 256122 [details] Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5

Chris Dumez

Comment 8 2015-07-03 14:44:03 PDT

Created attachment 256123 [details] Patch

WebKit Commit Bot

Comment 9 2015-07-03 20:57:17 PDT

Comment on attachment 256123 [details] Patch Clearing flags on attachment: 256123 Committed r186275: <http://trac.webkit.org/changeset/186275>

WebKit Commit Bot

Comment 10 2015-07-03 20:57:22 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.